Add the ability to specify "scope or unknown" via COM #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
approved these changes
Aug 2, 2022
yao-msft
reviewed
Aug 2, 2022
| { | ||
| testContext.Add<Data::AllowUnknownScope>(true); | ||
|
|
||
| ManifestComparator mc(ManifestComparatorTestContext{}, {}); |
There was a problem hiding this comment.
Not a nit, a copy-paste error that ends up not testing at all...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Adds two new scope options for COM;
UserOrUnknownandSystemOrUnknown. These will allow the installer selection to consider both the specific scope, as well as an unknown scope.Validation
Unit tests and COM E2E tests are added for the scenario.
Microsoft Reviewers: Open in CodeFlow