Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #2378

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Logging improvements #2378

merged 2 commits into from
Jul 26, 2022

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Jul 26, 2022

Change

Add a connection identifier and log it when opening the connection and with each statement. This makes it somewhat easier to follow the (extremely) verbose SQLite logging.

Also changes the file logger to append by default, enabling logging to the same file repeatedly a possibility (a util scenario mostly).

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner July 26, 2022 21:41
@Trenly
Copy link
Contributor

Trenly commented Jul 26, 2022

Also changes the file logger to append by default, enabling logging to the same file repeatedly a possibility (a util scenario mostly).

Just clarifying - This will still create a new log file for each command, but just enables future possibility to log to the same file, correct?

@JohnMcPMS
Copy link
Member Author

Correct, there should be no change at all to the behavior of winget.exe here. This is only to make some scenarios work better for other places were we use the code.

@JohnMcPMS JohnMcPMS merged commit 0a66b93 into microsoft:master Jul 26, 2022
@JohnMcPMS JohnMcPMS deleted the log-conn branch July 26, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants