Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UndockedRegFreeWinRT as subtree #2330

Closed
wants to merge 2 commits into from

Conversation

jontab
Copy link
Contributor

@jontab jontab commented Jul 12, 2022

This adds the src/UndockedRegFreeWinRT directory from the master branch of https://github.com/microsoft/xlang as a subtree in the src directory.

Microsoft Reviewers: Open in CodeFlow

git-subtree-dir: src/UndockedRegFreeWinRT
git-subtree-split: d535194bf9e2ae982e5e635b0c93e39b2829f790
@jontab jontab requested a review from a team as a code owner July 12, 2022 23:19
@github-actions

This comment was marked as outdated.

@Trenly
Copy link
Contributor

Trenly commented Jul 13, 2022

Out of curiosity, is there a reason for including the entire source tree instead of just using the NuGet package?

@JohnMcPMS
Copy link
Member

Out of curiosity, is there a reason for including the entire source tree instead of just using the NuGet package?

Because we are going to make changes to it as it doesn't actually work for the scenario. This is a stopgap for either coming to a design that is supported more broadly (and then we can use the NuGet) or implementing one of the other options for getting the COM proxies working.

@JohnMcPMS
Copy link
Member

@jontab We typically subtree these into a subdirectory under the src/FOO location so that we can put our files (like the project) in that root. I think given that we fully intend to make changes to this subtree it is ok to do it the way you have it now, just letting you know.

@JohnMcPMS
Copy link
Member

Done by #2333

@JohnMcPMS JohnMcPMS closed this Jul 13, 2022
@jontab jontab deleted the user/t-jabbott/undocked branch August 2, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants