-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize 'Show' labels to manifest fields #2311
Conversation
We had a discussion internally a while back related to the labels. Part of the reason we were exposing the exact "YAML" key values is because we weren't localizing the titles. I'm not sure how well this plays from a localization perspective. Thoughts? |
Hmmm. I'm not sure either. I think from a contributor perspective, I would rather see exact YAML keys (spaces added) as it provides simpler correlation between fields. From a user perspective, I would want the fields to be localized so I could understand what each of them were. However, I would say that there is a fairly clear link between the Yaml keys and the meaning of the key. From an english-First perspective, I don't see any reason not to update the keys. From a localized perspective, I can see how it could make the localization more difficult to understand. |
I wonder how "jarring" the experience would be for individuals to see localized labels and en-US descriptions when the package metadata hasn't been localized. I expect that's the experience they are dealing with today. Given the manifest keys are en-US based and we would display the localized values mixed with en-US values it's probably already an inconsistent experience. Maybe localizing the titles would improve the experience for manifests with localizations. We've got a feature on wingetcreate to make localizing metadata easier: I think I'm good going down the path of localizing the titles. @JohnMcPMS thoughts? |
The "titles"? As in the field name parts in winget-cli/Localization/Resources/de-DE/winget.resw Lines 1033 to 1035 in a56372b
|
I think last time we discussed that we would de-localize the manifest keys for show, for scenarios Demitrius mentioned. Are we ok not doing that now? |
If they are already localized, yes. The changes we're making here should be fine. There may be better renditions for things like "URL" as opposed to "Url" where the casing is unique to YAML/JSON styles. |
c4b2766
to
4257532
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Not that a build is needed... just following protocol. |
Microsoft Reviewers: Open in CodeFlow