Skip to content

Add missing localization error handling for root level localization info - #2220

Merged
JohnMcPMS merged 1 commit into
microsoft:masterfrom
JohnMcPMS:fix-loc
Jun 6, 2022
Merged

JohnMcPMS merged 1 commit into
microsoft:masterfrom
JohnMcPMS:fix-loc

Conversation

@JohnMcPMS

@JohnMcPMS JohnMcPMS commented Jun 6, 2022 •

Copy link
Copy Markdown
Member

Fixes #2218

Change

Add the missing "treat errors as warnings" bool for the root level localization validation. It was previously applied to the other non-root localizations, but the root was missed.

Validation

Fixed the reported bug (manually verified), unit tests continue to pass.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS
JohnMcPMS requested a review from a team as a code owner June 6, 2022 17:33
@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jun 6, 2022
@JohnMcPMS
JohnMcPMS merged commit 9d34634 into microsoft:master Jun 6, 2022
@JohnMcPMS
JohnMcPMS deleted the fix-loc branch June 6, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Bug It either shouldn't be doing this or needs an investigation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Searching for dotnet package

2 participants