Repository navigation
Fix issue with correlation chaining from the SQLite index - #2087
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
yao-msft
reviewed
Apr 12, 2022
| PackageData& data) | ||
| { | ||
| // Unfortunately the names and publishers are unique and not tied to each other strictly, so we need | ||
| // to go broad on the matches. Future work can hopefully make name and publisher work closer to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The composite source correlation was using the name + publisher values in a very optimistic way, which was leading to the potential for some values to get lost. This change creates a search on the cartesian product of the values, which is more expensive but also more correct.
Also includes another option for the correlation test exe to skip the install for testing/debugging purposes. Also again, updates the winmd because I think that the IID for WinRT is based on a hash of the interface definition, and the change to the contract 4 interface broke the existing file.
Microsoft Reviewers: Open in CodeFlow