[Easton Pillay (jedieaston)]

• Have you signed the Contributor License Agreement?
• Are you working against an Issue?

---

Resolves #1925 (yes, I know it was my issue. just had to leave myself a reminder :D)

This PR adds the system architecture to winget --info, cutting out the first question we usually ask when troubleshooting.

Microsoft Reviewers: Open in CodeFlow

[JohnMcPMS]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yao-msft]

We haven't enforced the output rule yet, but I think the Utility::ToString(Utility::GetSystemArchitecture()) needs to be wrapped inside LocIndString

[JohnMcPMS]

Utility::ToString(Architecture) could probably be changed to return a loc independent view. If it turns out we need to localize it in the future, that can be its own problem.

[yao-msft]

nit: shall we match the variable name with the value so we don't misuse this in the future?

[Easton Pillay (jedieaston)]

Sorry for the delay, I made it localization independent when the command is called. I tried to do as JohnMcPMS suggested and just change the type to LocIndView, but since LocIndView is also defined inside of that project, it seemed to create a circular dependency somehow (although since LocIndView wasn't relying on anything in AppInstallerArchitecture.h, I'm not sure why). Does anyone have any ideas on how to fix that?

[yao-msft]

Sorry for the delay, I made it localization independent when the command is called. I tried to do as JohnMcPMS suggested and just change the type to LocIndView, but since LocIndView is also defined inside of that project, it seemed to create a circular dependency somehow (although since LocIndView wasn't relying on anything in AppInstallerArchitecture.h, I'm not sure why). Does anyone have any ideas on how to fix that?

I just tried adding #include "winget/LocIndependent.h" to AppInstallerArchitectures.h and modified the declaration and definition of the method. I did not see circular dependency in rebuilding. If somehow this still won't work for you, I'm fine with merging with current code. Just let me know. Thanks.

[Easton Pillay (jedieaston)]

It was the missing header :(

Thanks yao-msft.

[yao-msft]

To make code a bit cleaner and consistent with other places. We may want to use our custom string literals(_liv).

        using namespace literals;

        switch (architecture)
        {
        case Architecture::Neutral:
            return "Neutral"_liv;
        case Architecture::X86:
            return "X86"_liv;
        case Architecture::X64:
            return "X64"_liv;
        case Architecture::Arm:
            return "Arm"_liv;
        case Architecture::Arm64:
            return "Arm64"_liv;
        }

        return "Unknown"_liv;

[Easton Pillay (jedieaston)]

I tried to use them but was missing the namespace. Oops, my header game is weak this week.

[Demitrius Nelon (denelon)]

Does this work in the Sandbox? I submitted an Issue for "Screen To Gif". I wanted to make sure we're checking the host architecture, for this scenario or at least be aware of limitations.

[yao-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Easton Pillay (jedieaston)]

Does this work in the Sandbox? I submitted an Issue for "Screen To Gif". I wanted to make sure we're checking the host architecture, for this scenario or at least be aware of limitations.

Sorry I didn't get to this sooner, yes it works in the Sandbox.