ArchiSteamFarm upgrade removes config file

[waltzInCSharpMajor]

Brief description of your issue

ArchiSteamFarm (ASF) stores important configuration files that contain information like login details and settings in "/config". However, it seems that Winget completely wipes the folder when upgrading ASF, deleting the directory and replacing it with an empty one. As such, one would need to set up everything again.

I'm not sure if its related, but, though successfully upgrading ASF (ASF runs with the new version), Winget gives the following error at the end (my username is redacted for privacy):

An unexpected error occurred while executing the command:
copy_file: unknown error: "C:\Users\(username)\AppData\Local\Temp\WinGet\JustArchiNET.ArchiSteamFarm.6.1.4.3\extracted\logs", "C:\Users\(username)\AppData\Local\Microsoft\WinGet\Packages\JustArchiNET.ArchiSteamFarm_Microsoft.Winget.Source_8wekyb3d8bbwe\logs"
Installer failed with exit code: 0x8a150003 : Executing command failed

The following is the full Winget log file (again my username has been redacted):
WinGet-2025-04-03-09-10-45.370.log

Steps to reproduce

1. Wait for ASF to have an update
2. Upgrade ASF using Winget

Expected behavior

Winget would upgrade ASF without tampering with any pre-existing data

Actual behavior

Winget removes all configuration files

Environment

Windows: Windows.Desktop v10.0.26100.3624
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.25.340.0

[denelon]

I took a look at the latest manifest:
https://github.com/microsoft/winget-pkgs/blob/master/manifests/j/JustArchiNET/ArchiSteamFarm/6.1.4.3/JustArchiNET.ArchiSteamFarm.installer.yaml

I originally suspected the upgrade behavior might be set to uninstall previous, but it is not. Since this is a portable application, the next thing I'm thinking is the directory being created for the "upgraded" version includes the package version number. In that case, the previous configuration data is in the "old" directory.

The error is coming from WinGet (App Installer) in this case (image below). Is there any chance you could help me set up a reproduction? I'm not familiar with that package, so I don't know what would need to be done to create/get the configuration data. I'm expecting something like install the n-1 version of the package, run it (with some command/argument) to get settings, and then run winget upgrade JustArchiNET.ArchiSteamFarm.

[Trenly]

@denelon - I believe this is a CLI edge case, but also (likely) two separate bugs.

The first bug is that during the uninstall process, WinGet seems to remove the directory.

2025-04-03 09:11:46.214 [CLI ] Removing directory at C:\Users\(username)\AppData\Local\Microsoft\WinGet\Packages\JustArchiNET.ArchiSteamFarm_Microsoft.Winget.Source_8wekyb3d8bbwe\config

This is likely because WinGet does place down the directory during the install flow. During the uninstall flow, WinGet should try and keep any files that it did not lay down. Therefore, the first bug is that the directory itself is being removed.

The second bug I see is actually an artifact of what should be the proper behavior, but is also being handled incorrectly. In this case, the logs folder. In each release, it seems the Zip file does contain a logs directory that has just a .gitkeep file in it, similar to the config directory. However, that folder is not being removed during the uninstall phase, and then during the install phase, the rename fails because the folder is already existing (and likely has logs in it)

2025-04-03 09:11:46.456 [FAIL] C:\__w\1\s\external\pkg\src\AppInstallerSharedLib\Filesystem.cpp(183)\WindowsPackageManager.dll!00007FFE1C006265: (caller: 00007FFE1BE17CAC) LogHr(4) tid(95b8) 8007023E {Application Error}
The exception %s (0x    Msg:[std::exception: rename: unknown error: "C:\Users\(username)\AppData\Local\Temp\WinGet\JustArchiNET.ArchiSteamFarm.6.1.4.3\extracted\logs", "C:\Users\(username)\AppData\Local\Microsoft\WinGet\Packages\JustArchiNET.ArchiSteamFarm_Microsoft.Winget.Source_8wekyb3d8bbwe\logs"]

---

This would mean two things need to be fixed / investigated -

1. Why is config getting removed, if it contains files that were not created by WinGet?
2. When performing an upgrade, if the directory already exists, the individual files inside the directory need to be copied over as renaming the directory will fail

[waltzInCSharpMajor]

Hi, just some additional information which may or may not help. I checked my Winget ArchiSteamFarm folder (C:\Users\(username)\AppData\Local\Microsoft\WinGet\Packages\JustArchiNET.ArchiSteamFarm_Microsoft.Winget.Source_8wekyb3d8bbwe) and it seems like despite the copy error, my logs folder does still contain all my logs prior to upgrading ASF with Winget. At the same time, it does still also have a .gitkeep file in it, so it's a bit strange. My plugins folder also has all of its previous data but also a .gitkeep file. On the other hand, my config folder also has a .gitkeep file, but other than that it is empty.