Add item indexing support to windows-metadata
#3612
Merged
+191
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #3562 to add item indexing support to the
windows-metadatareader - this is a slightly higher-level index needed to quickly look up Win32-style global types, functions and constants. This is needed for the eventual replacement of thewindows-bindgenmetadata reader and just generally makes it a lot easier to develop tooling for COM and Win32-style APIs.The
TypeIndexprovides indexing over the ECMA-335TypeDeftable that inexplicably never provided sorting directly. TheItemIndexprovides indexing on top of that while further categorizing. If you're only working with WinRT metadata then theTypeIndexshould suffice.