Skip to content

Remove rayon dependency #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Remove rayon dependency #3588

merged 1 commit into from
Apr 30, 2025

Conversation

kennykerr
Copy link
Collaborator

This is only used to speed up package generation, which is mostly just for the generation of the windows and windows-sys crates, by parallelizing code generation. Unfortunately, it has proven unreliable on Windows. I'll likely provide a simple parallelizing replacement in the near future.

@ChrisDenton
Copy link
Collaborator

ChrisDenton commented Apr 29, 2025

I'm all for simplifying the dependency tree but was there a particular issue motivating this?

@kennykerr
Copy link
Collaborator Author

was there a particular issue motivating this

Running cargo run -p tool_bindings --release hangs my entire machine pretty regularly. At least once or twice a day I'm forced to hard reboot my dev box... This does not happen with my C++ code generators, which hammer the machine at least as hard.

@kennykerr kennykerr merged commit e404859 into master Apr 30, 2025
29 checks passed
@kennykerr kennykerr deleted the remove-rayon branch April 30, 2025 00:48
@MRahilly
Copy link

Possibly like the file system churn that C++/WinRT implementation headers generate on an older PC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants