Allow the name and value in set_string to be 2 different types

[kerosina]

Currently, windows_registry::key::Key::set_string takes one generic type T which implements AsRef<str>, which is the type of the arguments name and value. This signature is too restrictive, since both arguments must be of the same concrete type, while it should accept, for example, key.set_string(String::from("Name"),"Value").

This PR adds a new generic type U, with the same trait bound as T and which is the type of value, thereby allowing the aforementioned situation and similar cases where the 2 arguments have different concrete types that fulfill the same trait bound.

Fixes: #3313

[kennykerr]

Thanks for the contribution. Is this an attempt to fix #3313?

[kerosina]

Thanks for the contribution. Is this an attempt to fix #3313?

Didn't realize there already existed an issue about this. But yes, it fixes #3313

[kennykerr]

OK, how about the other methods mentioned in that issue like set_expand_string? Also we'd need a simple test that validates this in the test_registry crate.

[kerosina]

@microsoft-github-policy-service agree

[kennykerr]

Please append the new tests rather than rewriting existing tests - that way we know the existing tested code continues to work without much reasoning.

Also, please actually test the changes before pushing a PR. 😉

"lolz" != "value"

[kerosina]

Sorry, copy pasted from rust playground and didn't realize I changed the value name.

[kerosina]

BTW, I didn't update set_multi_string's signature since it would break code which passed an empty array (with an inferred type), but, if windows-registry is about to have a major version bump, do you think the tradeoff would be worth it?

[kennykerr]

Passing an empty array seems like a perfectly reasonable thing to do so I'd rather not break that. 😊