Add Linux smoke test #3005
Merged
Add Linux smoke test #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
commented
Apr 19, 2024
Comment on lines
+9
to
+11
| // TODO: https://github.com/microsoft/windows-rs/pull/3004 should enable the following test. | ||
| // let w: PCWSTR = w!("wide world"); | ||
| // assert_eq!(w.to_string().unwrap(), "wide world"); |
There was a problem hiding this comment.
@tyilo please uncomment this test in your PR... once I merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Linux smoke test was compiling for a Linux target but not actually running any tests. This updates yml to actually test the code and repurposes the simple test component to actually test something interesting: the difference between
wcslenon Windows and Linux.This test should fail because of: #2996