-
Notifications
You must be signed in to change notification settings - Fork 120
feat(cargo-wdk): support target architecture override through config.toml and CARGO_BUILD_TARGET
#494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(cargo-wdk): support target architecture override through config.toml and CARGO_BUILD_TARGET
#494
Changes from all commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
6a160e2
Refactor target architecture handling and command execution
svasista-ms a5c6f70
fix: skip packaging if target kind is not cdylib
svasista-ms 0da33be
Merge branch 'main' into support-target-overrides
svasista-ms 778939a
Merge remote-tracking branch 'origin/main' into support-target-overri…
svasista-ms 1fc4ff6
- Added `resolve_final_artifacts_root` method to determine the archit…
svasista-ms 61b1f5d
Merge branch 'main' into support-target-overrides
svasista-ms b980aa9
fix: update test workflow and test assertions.
svasista-ms 20e207d
Refactor BuildAction to handle target_arch cases and improve packagin…
svasista-ms 32dfb50
fix typos
svasista-ms 09170ba
address Copilot's comments
svasista-ms 1d804c0
Merge main into support-target-overrides:
svasista-ms 2e0f588
check if the order of targets matters for the default target selection.
svasista-ms 1f9d721
fix expect in build_command_test
svasista-ms ca4391f
fix lock scope in build_command_test
svasista-ms 238c3c0
fix clippy issues
svasista-ms 31e25ee
fix tests
svasista-ms 065de7d
refactor: improve file locking mechanism and error handling in test u…
svasista-ms cdcb8c7
fix: locating Windows SDK packages in install-wdk action
svasista-ms 4d261ef
fix: update SDK package version variable in WDK installation action
svasista-ms 5cef038
fix: use input version for SDK package display name and version in WD…
svasista-ms dd23931
fix: add CARGO_WDK_NUGET_PACKAGE_ROOT environment variable to WDK con…
svasista-ms 7eebd31
fix: update architecture descriptions and output variable names in WD…
svasista-ms db07ad8
Merge branch 'main' into support-target-overrides
svasista-ms 2e85f00
fix: install-wdk action outputs and build_command_test
svasista-ms e3ed601
fix: correct environment variable name for NuGet package root in buil…
svasista-ms c6d8156
fix clippy issues
svasista-ms 6e24606
fix: clippy issues in the newly added test code
svasista-ms f037f52
fix: enabled other workflows and testing with configure-wdk.env action
svasista-ms a4128bb
fix: update WDK environment configuration by removing sdk-version-num…
svasista-ms 2f16baf
fix: remove sdk-version-number output from WDK installation action an…
svasista-ms 7d7c38d
fix: update architecture handling and improve WDK installation process
svasista-ms d65d3a3
fix: append '.0' to version number in WDK environment configuration
svasista-ms 203ac0a
fix: add targets for Rust toolchain installation in test workflow
svasista-ms 45243e1
address Copilot's comments
svasista-ms 1049978
fix `expect_detect_wdk_build_number` in tests and change error types …
svasista-ms 1ae3cf9
- Refactored `BuildTask::run` and `BuildAction::build_and_package` me…
svasista-ms 4588739
Refactor WDK environment configuration in GitHub workflows
svasista-ms d7a355e
fix: newline at end of file in test workflow
svasista-ms f8a00e4
fix: update error handling for host and target architecture inputs in…
svasista-ms 26dc5bf
fix: package type descriptions in install-wdk action
svasista-ms fb334d7
fix: remove panic in FileLockGuard drop impl
svasista-ms cf55edc
fix: parser error in install-wdk action
svasista-ms af54c7f
fix: remove explicit call to FileLockGuard drop
svasista-ms 70fa3e8
fix typo
svasista-ms 2d1d773
fix parser error in install-wdk action
svasista-ms 8ef4fed
fix: make target input required for WDK installation
svasista-ms d155b98
fix: install-wdk action and build_command_test
svasista-ms 8736eb4
remove print statements in tests
svasista-ms 2c1d3f4
fix: install all supported targets in install Rust toolchain step in …
svasista-ms 063d26d
fix: wdk-macros-tests Cargo.toml and Cargo.lock files
svasista-ms b01f75d
revert changes in `BuildAction` `run_from_workspace_root`
svasista-ms 84052a8
revert changes in `install-wdk` action
svasista-ms 7a4a83a
fix: use `CrateType` and `TargetKind` for cdylib detection in BuildAc…
svasista-ms 850ffb4
fix Cargo.lock file
svasista-ms 6f4282a
revert changes not related to this PR
svasista-ms 2d9f765
revert unrelated changes in install-wdk-action
svasista-ms 2c842f1
remove unrelated tests
svasista-ms 6e1586b
fix: update documentation for `run` method to clarify return type
svasista-ms 5fc0d81
Merge branch 'main' into support-target-overrides
svasista-ms e8614ee
revert variable name change: $fullVersionNumber back to $version
svasista-ms fbacce6
revert variable name change: $fullVersionNumber back to $version
svasista-ms 58c358f
revert $nugetPackagesRoot variable back to $packages for a cleaner diff
svasista-ms 2d49301
Remove unnecessary 'id' field from Install WDK step in multiple workf…
svasista-ms 50eab42
address comments
svasista-ms a22658b
revert changes in workflows
svasista-ms 139a290
revert additional changes in `BuildAction` tests and `install-wdk` ac…
svasista-ms abe37ea
fix logging statements in `BuildTask::run`
svasista-ms 9f5440b
remove unnecessary changes in `BuildAction` tests
svasista-ms 2e358ce
fix documentation and revert changes in `BuildTask::run` method
svasista-ms 286f611
revert `PATH` env setup change
svasista-ms a973e24
fix `get_target_dir_for_packaging` comment
svasista-ms 4f8fd1f
fix `BuildAction::run()` documentation
svasista-ms 3eafc0e
revert changes in log statements in `build_and_package`
svasista-ms 3c7d046
test: packaging should fail when target arch is not provided and prob…
svasista-ms e20b7f7
fix `probe_target_arch_from_cargo_rustc` documentation
svasista-ms a9c7837
fix typo in `probe_target_arch_from_cargo_rustc` documentation
svasista-ms 4effd32
fix: hardcode profile and target triple in `run_invokes_cargo_build_w…
svasista-ms 1a1f9b7
Merge branch 'main' into support-target-overrides
svasista-ms c4d3a8b
fix: update WDKBinRoot and WDKToolRoot paths to include SDK version
svasista-ms 476556f
fix: update `kmdf-driver-with-target-override` test fixture's Cargo.lock
svasista-ms 193add3
address review comments
svasista-ms 40612d5
Merge branch 'main' into support-target-overrides.
svasista-ms 6f0741f
Revert "Merge branch 'main' into support-target-overrides."
svasista-ms f645238
Merge branch 'main' into support-target-overrides
svasista-ms feb2f51
update Cargo.lock
svasista-ms d8424cb
fix files affected because of merge conflicts
svasista-ms 3af0692
fix files affected because of merge conflicts
svasista-ms 69e661e
fix `BuildAction` tests
svasista-ms 70fcc29
fix issue in `PackageTaskError`, corrected the order in which error v…
svasista-ms 4f7332a
address comments
svasista-ms 59832bb
fix tests
svasista-ms 7dceec0
refactor build command tests to simplify environment variable handling
svasista-ms c2b9741
fix: update package directory name formatting in NuGet content root f…
svasista-ms 6131ea3
refactor: disable rust-analyzer on cargo-wdk test fixtures
svasista-ms f55fee8
Merge branch 'main' into support-target-overrides
svasista-ms aa47db1
refactor: rename test for clarity on target override precedence and a…
svasista-ms cf1e0da
refactor: simplify WDK content root retrieval from NuGet packages
svasista-ms f1ce41c
address review comments
svasista-ms b092fcc
Merge branch 'main' into support-target-overrides
svasista-ms 4919e99
address comments
svasista-ms 42352a6
test: add additional tests to increase coverage of `BuildAction::get_…
svasista-ms 5d52958
address review comments
svasista-ms 9203c82
fix(ci): update package directory variable in install-wdk action
svasista-ms ce754a5
address review comments
svasista-ms 47c1457
refactor: move project_path position in `clean_build_and_verify_project`
svasista-ms b62c701
revert changes under `rust-analyzer.linkedProjects`
svasista-ms dce7bc2
refactor test names
svasista-ms e7d0148
refactor build action tests
svasista-ms 16056c4
remove unnecessary comments in install-wdk action
svasista-ms 2ce4f10
Merge branch 'microsoft:main' into support-target-overrides
svasista-ms bbb35da
refactor: improve whitespace handling in `get_target_arch_from_cargo_…
svasista-ms 06022bc
Merge branch 'microsoft:main' into support-target-overrides
svasista-ms 8549d4e
refactor: reorganize target override tests
svasista-ms dd69bb3
refactor: enhance cross-compilation support and environment variable …
svasista-ms 8f73c09
fix: replace `map().unwrap_or()` with `is_some_and()` (clippy)
svasista-ms 34c782e
fix: update target architecture from `x64` to `AMD64`
svasista-ms c7c1086
fix: normalize target architecture for NuGet WDK package folder names…
svasista-ms 0f2433e
fix: ensure target directory is absolute in get_target_dir_from_outpu…
svasista-ms 014fa50
fix: correct typo in documentation
svasista-ms 0a119f7
fix: update target architecture string for ARM64 in nuget_wdk_content…
svasista-ms bdec8e3
fix: refactor target architecture parsing in get_target_arch_from_car…
svasista-ms c6d39d4
fix: clarify normalization logic for NuGet WDK package folder names i…
svasista-ms e7e5d58
fix: add newline at end of settings.json file
svasista-ms 13d0785
fix: use strip_prefix in get_target_arch_from_cargo_rustc function to…
svasista-ms 5210f70
fix: use strip_prefix in get_target_arch_from_cargo_rustc function to…
svasista-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.