feat: enhance debug tracing in bindgen and config modules#455
Merged
wmmc88 merged 2 commits intomicrosoft:mainfrom Sep 25, 2025
Merged
feat: enhance debug tracing in bindgen and config modules#455wmmc88 merged 2 commits intomicrosoft:mainfrom
wmmc88 merged 2 commits intomicrosoft:mainfrom
Conversation
Collaborator
Author
|
blocking on #451 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances debug tracing capabilities in the bindgen and config modules of the WDK crate, addressing issue #454. The changes focus on improving observability during build processes and fixing configuration handling.
- Adds comprehensive tracing instrumentation to configuration and bindgen functions
- Fixes cargo metadata resolution to respect config.toml overrides by setting proper working directories
- Includes test workspace improvements and minor corrections
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/wdk-build/src/lib.rs | Adds tracing instrumentation to Config methods and fixes cargo metadata working directory |
| crates/wdk-build/src/bindgen.rs | Adds tracing to bindgen functions and fixes metadata command working directory |
| crates/cargo-wdk/src/providers/exec.rs | Adds working_dir parameter to CommandExec run method |
| crates/cargo-wdk/src/cli.rs | Updates CommandExec run method calls to include working_dir parameter |
| crates/cargo-wdk/src/actions/build/build_task.rs | Updates build task to use working directory for cargo commands |
| crates/cargo-wdk/src/actions/build/package_task.rs | Updates package task command calls and fixes typo |
| crates/cargo-wdk/src/actions/new/mod.rs | Updates command exec calls and fixes typo |
| crates/cargo-wdk/src/actions/build/tests.rs | Updates test mocks to include working_dir parameter |
| tests/wdk-macros-tests/src/lib.rs | Fixes spelling error in comment |
| tests/umdf-driver-workspace/Cargo.toml | Simplifies workspace dependency declarations |
| tests/mixed-package-kmdf-workspace/Cargo.toml | Simplifies workspace dependency declarations |
| tests/mixed-package-kmdf-workspace/crates/driver/Cargo.toml | Disables tests for Windows Server 2022 compatibility |
| tests/customized-config-toml-workspace/ | Adds new test workspace for config.toml patch testing |
| tests/Makefile.toml | Adds new test workspace to cargo-make configuration |
| .github/workflows/test.yaml | Adds cargo-make testing for top-level tests folder |
| .github/workflows/build.yaml | Adds build and package steps for tests folder |
2aef442 to
3f589ff
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gurry
approved these changes
Sep 25, 2025
krishnakumar4a4
requested changes
Sep 25, 2025
krishnakumar4a4
approved these changes
Sep 25, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #454