Skip to content

Update winapp new to warn when scaffolding is taking longer than expected - #756

Open
Zach Teutsch (zateutsch) wants to merge 6 commits into
mainfrom
zt/752-warn-sdk-download-nw
Open

Update winapp new to warn when scaffolding is taking longer than expected#756
Zach Teutsch (zateutsch) wants to merge 6 commits into
mainfrom
zt/752-warn-sdk-download-nw

Conversation

@zateutsch

Copy link
Copy Markdown
Contributor

Summary

Updates winapp new to provide clearer feedback when project scaffolding takes longer than expected.

  • Keeps the existing scaffold spinner for the first 10 seconds.
  • If scaffolding is still running, changes the status to:

    Still setting up the project; missing NuGet packages may be downloading or restoring…

  • Uses elapsed time rather than parsing dotnet new output, preserving localized verbose and error messages.
  • Leaves --json, --quiet, redirected output, CI, and other non-interactive behavior unchanged.

Fixes #752.

Testing

  • Built src\winapp-CLI\winapp.sln in Release with 0 warnings and 0 errors.
  • Ran 139 focused NewCommand tests successfully.
  • Published the ARM64 CLI and used the published binary to create a real WinUI project with the installed template pack.
  • Ran the PR review skill; no critical or high findings remained after validation and gut check.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b0a2574d-4757-4a27-8c6a-87aa99e74da0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b0a2574d-4757-4a27-8c6a-87aa99e74da0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b0a2574d-4757-4a27-8c6a-87aa99e74da0
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Build Metrics Report

Binary Sizes

Artifact Baseline Current Delta
CLI (ARM64) 38.62 MB 38.63 MB 📈 +6.0 KB (+0.02%)
CLI (x64) 38.74 MB 38.74 MB 📈 +5.0 KB (+0.01%)
MSIX (ARM64) 16.02 MB 16.02 MB 📈 +1.5 KB (+0.01%)
MSIX (x64) 17.02 MB 17.02 MB 📈 +5.4 KB (+0.03%)
NPM Package 33.42 MB 33.42 MB 📈 +3.7 KB (+0.01%)
NuGet Package 33.46 MB 33.47 MB 📈 +6.6 KB (+0.02%)

Test Results

4579 passed, 5 skipped out of 4584 tests in 640.0s (+3 tests, +26.2s vs. baseline)

Test Coverage

89.1% line coverage, 82.4% branch coverage · ✅ no change vs. baseline

CLI Startup Time

55ms median (x64, winapp --version) · ✅ +9ms vs. baseline

Try This Build

Installs the MSIX for your architecture, replacing any previously installed build. Needs the GitHub CLI — the command offers to install it and sign you in if it is missing.

& ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) 756
Switching between builds often?

Put the tool on your PATH once:

& ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) -AddToPath

Then this build is just:

winapp-pr 756

Run winapp-pr with no arguments to pick from a list of open PRs.


Updated 2026-08-14 21:20:33 UTC · commit 1ebb208 · workflow run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates winapp new to provide delayed scaffolding feedback while preserving non-interactive behavior.

Changes:

  • Changes the spinner message after 10 seconds.
  • Adds documentation for slow package restoration.
  • Adds a timeout-value test and refreshes generated schema metadata.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
NewCommand.cs Implements delayed spinner status.
NewCommandTests.cs Tests the configured delay.
winapp-commands.ts Updates generated schema version.
SKILL.md Documents delayed scaffolding feedback.
docs/usage.md Explains slow first-run behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/winapp-CLI/WinApp.Cli.Tests/NewCommandTests.cs
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b0a2574d-4757-4a27-8c6a-87aa99e74da0
@zateutsch
Zach Teutsch (zateutsch) marked this pull request as ready for review August 15, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Detect when WinUI templates need to resolve WASDK and display loading text

2 participants