Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the create-debug-identity command incorrectly reported that Developer Mode was not enabled, even when users had enabled it through Windows Settings. The issue was caused by the developer mode check requiring two registry keys instead of just the primary one.
Changes:
- Simplified the developer mode detection logic in
DevModeService.IsEnabled()to only check theAllowDevelopmentWithoutDevLicenseregistry key, removing the unnecessary check forAllowAllTrustedApps(sideloading)
Build Metrics ReportBinary Sizes
Test Results✅ 248 passed, 6 skipped out of 254 tests in 60.7s (+14.6s vs. baseline) CLI Startup Time30ms median (x64, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #303
Type of Change
Checklist
AI Description
This change modifies the
IsEnabledmethod in theDevModeServiceclass to only check the "AllowDevelopmentWithoutDevLicense" registry key, removing the check for "AllowAllTrustedApps." This adjustment addresses the issue described in bug #303 by simplifying the logic for determining if development mode is enabled.