cmake : Add install target to support consuming WIL through cmake. #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
p-groarke
commented
May 2, 2020
| cmake_minimum_required(VERSION 3.11) | ||
| project(WIL) | ||
|
|
||
| include(GNUInstallDirs) |
Contributor
Author
There was a problem hiding this comment.
Required by install.
p-groarke
commented
May 2, 2020
| endif() | ||
|
|
||
| # Gather headers into an interface library. | ||
| file(GLOB_RECURSE HEADER_FILES "${PROJECT_SOURCE_DIR}/include/${PROJECT_NAME}/*.h") |
Contributor
Author
There was a problem hiding this comment.
Adds the INTERFACE target.
p-groarke
commented
May 2, 2020
| file(GLOB_RECURSE HEADER_FILES "${PROJECT_SOURCE_DIR}/include/${PROJECT_NAME}/*.h") | ||
| add_library(${PROJECT_NAME} INTERFACE) | ||
|
|
||
| # The interface's include directory. |
Contributor
Author
There was a problem hiding this comment.
The following installs all cmake required files to find the library.
p-groarke
commented
May 2, 2020
| @@ -1,8 +1,8 @@ | |||
|
|
|||
| include(${CMAKE_SOURCE_DIR}/cmake/common_build_flags.cmake) | |||
| include(${PROJECT_SOURCE_DIR}/cmake/common_build_flags.cmake) | |||
Contributor
Author
There was a problem hiding this comment.
PROJECT_SOURCE_DIR is required when running through ExternalProject or FetchContent.
dunhor
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow a user to install WIL using cmake and consume it through available cmake mechanisms like
find_package,ExternalProject_AddorFetchContent.You can install it locally using the following command :
INTERFACEtarget for the headers.Unit tests were ran and passed.