Skip invalid additional probing paths #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet/sdk#1306 brought in templated probing paths into the runtime.config.json. These are breaking dotnet test because we assume the paths are valid. Skipping any invalid paths by catching exceptions from Path.Combine. Fixes microsoft#847
|
@eerhardt, |
livarcocc
approved these changes
Jun 8, 2017
|
@dotnet-bot Test Windows_NT / Release Build |
|
@dotnet-bot test Windows_NT / Release Build |
|
@dotnet-bot test this please |
codito
approved these changes
Jun 9, 2017
|
Please treat this with the utmost urgency. This is currently blocking the SDK insertion into the CLI which in turn is blocking a bunch of work that is due tomorrow. |
|
This is green, can we go ahead and merge it? |
codito
pushed a commit
that referenced
this pull request
Jun 9, 2017
dotnet/sdk#1306 brought in templated probing paths into the runtime.config.json. These are breaking dotnet test because we assume the paths are valid. Skipping any invalid paths by catching exceptions from Path.Combine. Fixes #847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/sdk#1306 brought in templated probing paths into the runtime.config.json. These are breaking dotnet test because we assume the paths are valid.
Skipping any invalid paths by catching exceptions from Path.Combine.
Fixes #847
@codito @Faizan2304 @singhsarab
/cc @livarcocc