Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject entry point only for project targeting netcoreapp #665

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Inject entry point only for project targeting netcoreapp #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Issue: #608 
Fix: Inject entry point only for project targeting netcoreapp1.0
  • Loading branch information
faahmad authored and faahmad committed Mar 27, 2017
commit d37998fb8eaa93cff3b85a46e17cc29ee2664a83
2 changes: 1 addition & 1 deletion src/package/nuspec/Microsoft.NET.Test.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
Generates Program file which contains the Main entry point
============================================================
-->
<PropertyGroup>
<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general thought (not specific to this PR):
For every build of a netcore test project, we will create this file. Does this imply that the test project will be compiled again always? (even if no actual code has changed)

If this is true, can it be avoided?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, It will create only first time. Subsequent build and rebuild will use the same

<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
<GeneratedProgramFile Condition="'$(GeneratedProgramFile)' ==''">$(IntermediateOutputPath)$(MSBuildProjectName).Program$(DefaultLanguageSourceExtension)</GeneratedProgramFile>
<GenerateProgramFile Condition="'$(GenerateProgramFile)' == ''">true</GenerateProgramFile>
Expand Down