Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rawArgument in GetArgumentList cant be null #5056

Merged
merged 1 commit into from
May 23, 2024
Merged

rawArgument in GetArgumentList cant be null #5056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/vstest.console/Processors/Utilities/ArgumentProcessorUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,19 @@ internal class ArgumentProcessorUtilities
/// <param name="argumentSeparator">Argument separator.</param>
/// <param name="exceptionMessage">Exception Message.</param>
/// <returns>Argument list.</returns>
public static string[] GetArgumentList(string? rawArgument, char[] argumentSeparator, string exceptionMessage)
public static string[] GetArgumentList(string rawArgument, char[] argumentSeparator, string exceptionMessage)
{
var argumentList = rawArgument?.Split(argumentSeparator, StringSplitOptions.RemoveEmptyEntries);
var argumentList = rawArgument.Split(argumentSeparator, StringSplitOptions.RemoveEmptyEntries);

// Throw error in case of invalid argument.
return argumentList == null || argumentList.Length <= 0 ? throw new CommandLineException(exceptionMessage) : argumentList;
if (argumentList.Length <= 0)
{
throw new CommandLineException(exceptionMessage);
}
else
{
return argumentList;
}
}

/// <summary>
Expand Down