Console logger splits path using directory and alt directory separators #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
approved these changes
Aug 4, 2022
| @@ -765,7 +765,7 @@ private void TestRunCompleteHandler(object? sender, TestRunCompleteEventArgs e) | |||
| : $"({_targetFramework})"; | |||
|
|
|||
| var duration = GetFormattedDurationString(sourceSummary.Duration); | |||
| var sourceName = sd.Key.Split('\\').Last(); | |||
| var sourceName = sd.Key.Split(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar).Last(); | |||
There was a problem hiding this comment.
Could Path.GetFileName be used here? It handles both normal and alt separator char. But does not handle UNC paths well. So maybe this is a lower risk option.
It still seems like a one-off solution of something that should be in a "library" and used everywhere. That is different discussion though.
There was a problem hiding this comment.
But does not handle UNC paths well
Do you know specific cases that are not well handled? Because replacing the code with Path.GetFileName seems pretty sensible to me.
Evangelink
force-pushed
the
console-logger-source-name
branch
from
057e974
to
e5e076d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Console logger splits path using directory and alt directory separators. I decided to use both separators because I have no idea if we are ensured to receive backslashes for windows paths.
Related issue
Fixes #3376