Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fakes packages #3912

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Update Fakes packages #3912

merged 6 commits into from
Aug 1, 2022

Conversation

vritant24
Copy link
Member

Description

Update Fakes package for the following changes:

  1. Add Arm support
  2. Fix issues in V2 for .exe files.

@Evangelink
Copy link
Member

Evangelink commented Aug 1, 2022 •
edited
Loading

I have relaunched CI steps to see if tests are flaky or if PR is impacting some tests.

EDIT: All green!

@AbhitejJohn Let us know if that's ready to be merged.

@vritant24
Copy link
Member Author

@Evangelink @AbhitejJohn
I've tested this locally, I think it should be good to merge

@Evangelink Evangelink enabled auto-merge (squash) August 1, 2022 16:13
@Evangelink Evangelink merged commit 84cd59e into microsoft:main Aug 1, 2022
@Evangelink
Copy link
Member

@AbhitejJohn @vritant24 Is 17.4 preview 2 enough?

@AbhitejJohn
Copy link
Contributor

AbhitejJohn commented Aug 1, 2022 •
edited
Loading

@Evangelink : yup, that should be good. Thanks for merging this in.

@AbhitejJohn AbhitejJohn mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@AbhitejJohn AbhitejJohn AbhitejJohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vritant24 @Evangelink @AbhitejJohn