Fix culture issues on cross plat engine

src/Microsoft.TestPlatform.CrossPlatEngine/AttachmentsProcessing/DataCollectorAttachmentProcessorAppDomain.cs

@@ -5,6 +5,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.IO;
 using System.IO.Pipes;
 using System.Linq;
@@ -124,7 +125,7 @@ private void PipeReaderTask()
                                 .SendMessage((TestMessageLevel)Enum.Parse(typeof(TestMessageLevel), prefix.Substring(prefix.LastIndexOf('.') + 1), false), message);
                             break;
                         case AppDomainPipeMessagePrefix.Report:
-                            _progressReporter?.Report(int.Parse(message));
+                            _progressReporter?.Report(int.Parse(message, CultureInfo.CurrentCulture));
                             break;
                         default:
                             EqtTrace.Error($"DataCollectorAttachmentProcessorAppDomain:PipeReaderTask: Unknown message: {message}");

src/Microsoft.TestPlatform.CrossPlatEngine/Client/Parallel/DiscoveryDataAggregator.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Threading;
 
@@ -141,11 +142,11 @@ public void AggregateMetrics(IDictionary<string, object>? metrics)
                 || metric.Key.Contains(TelemetryDataConstants.TotalTestsByAdapter)
                 || metric.Key.Contains(TelemetryDataConstants.TimeTakenToLoadAdaptersInSec))
             {
-                var newValue = Convert.ToDouble(metric.Value);
+                var newValue = Convert.ToDouble(metric.Value, CultureInfo.InvariantCulture);
 
                 if (_metricsAggregator.TryGetValue(metric.Key, out object? oldValue))
                 {
-                    double oldDoubleValue = Convert.ToDouble(oldValue);
+                    double oldDoubleValue = Convert.ToDouble(oldValue, CultureInfo.InvariantCulture);
                     _metricsAggregator[metric.Key] = newValue + oldDoubleValue;
                 }
                 else

src/Microsoft.TestPlatform.CrossPlatEngine/Client/Parallel/ParallelRunDataAggregator.cs

@@ -5,6 +5,7 @@
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.Globalization;
 using System.Linq;
 
 using Microsoft.VisualStudio.TestPlatform.Common.ExtensionFramework.Utilities;
@@ -194,11 +195,11 @@ public void AggregateRunDataMetrics(IDictionary<string, object>? metrics)
         {
             if (metric.Key.Contains(TelemetryDataConstants.TimeTakenToRunTestsByAnAdapter) || metric.Key.Contains(TelemetryDataConstants.TimeTakenByAllAdaptersInSec) || (metric.Key.Contains(TelemetryDataConstants.TotalTestsRun) || metric.Key.Contains(TelemetryDataConstants.TotalTestsRanByAdapter)))
             {
-                var newValue = Convert.ToDouble(metric.Value);
+                var newValue = Convert.ToDouble(metric.Value, CultureInfo.InvariantCulture);
 
                 if (_metricsAggregator.TryGetValue(metric.Key, out var oldValue))
                 {
-                    var oldDoubleValue = Convert.ToDouble(oldValue);
+                    var oldDoubleValue = Convert.ToDouble(oldValue, CultureInfo.InvariantCulture);
                     _metricsAggregator[metric.Key] = newValue + oldDoubleValue;
                 }
                 else

src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyDiscoveryManager.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 
 using Microsoft.VisualStudio.TestPlatform.Common;
@@ -323,7 +324,7 @@ private void InitializeExtensions(IEnumerable<string> sources)
         var nonExistingExtensions = extensions.Where(extension => !_fileHelper.Exists(extension));
         if (nonExistingExtensions.Any())
         {
-            LogMessage(TestMessageLevel.Warning, string.Format(Resources.Resources.NonExistingExtensions, string.Join(",", nonExistingExtensions)));
+            LogMessage(TestMessageLevel.Warning, string.Format(CultureInfo.CurrentCulture, Resources.Resources.NonExistingExtensions, string.Join(",", nonExistingExtensions)));
         }
 
         var sourceList = sources.ToList();

src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyExecutionManager.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.Globalization;
 using System.Linq;
 using System.Threading;
 
@@ -449,7 +450,7 @@ private void InitializeExtensions(IEnumerable<string> sources)
         var nonExistingExtensions = extensions.Where(extension => !_fileHelper.Exists(extension));
         if (nonExistingExtensions.Any())
         {
-            LogMessage(TestMessageLevel.Warning, string.Format(Resources.Resources.NonExistingExtensions, string.Join(",", nonExistingExtensions)));
+            LogMessage(TestMessageLevel.Warning, string.Format(CultureInfo.CurrentCulture, Resources.Resources.NonExistingExtensions, string.Join(",", nonExistingExtensions)));
         }
 
         var sourceList = sources.ToList();

src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs

@@ -229,10 +229,7 @@ public virtual bool SetupChannel(IEnumerable<string> sources, string? runSetting
             EqtTrace.Error("ProxyOperationManager: Failed to launch testhost :{0}", ex);
 
             CancellationTokenSource.Token.ThrowTestPlatformExceptionIfCancellationRequested();
-            throw new TestPlatformException(string.Format(
-                CultureInfo.CurrentUICulture,
-                CrossPlatEngineResources.FailedToLaunchTestHost,
-                ex.ToString()));
+            throw new TestPlatformException(string.Format(CultureInfo.CurrentCulture, CrossPlatEngineResources.FailedToLaunchTestHost, ex.ToString()));
         }
 
         // Warn the user that execution will wait for debugger attach.
@@ -251,6 +248,7 @@ public virtual bool SetupChannel(IEnumerable<string> sources, string? runSetting
 
             ConsoleOutput.Instance.WriteLine(
                 string.Format(
+                    CultureInfo.InvariantCulture,
                     "Process Id: {0}, Name: {1}",
                     _testHostProcessId,
                     _processHelper.GetProcessName(_testHostProcessId)),
@@ -412,8 +410,9 @@ public virtual TestProcessStartInfo UpdateTestProcessStartInfo(TestProcessStartI
             : Path.ChangeExtension(
                 logFile,
                 string.Format(
+                    CultureInfo.InvariantCulture,
                     "host.{0}_{1}{2}",
-                    DateTime.Now.ToString("yy-MM-dd_HH-mm-ss_fffff"),
+                    DateTime.Now.ToString("yy-MM-dd_HH-mm-ss_fffff", CultureInfo.InvariantCulture),
                     new PlatformEnvironment().GetCurrentManagedThreadId(),
                     Path.GetExtension(logFile))).AddDoubleQuote();
     }
@@ -465,7 +464,7 @@ private void ThrowOnTestHostExited(bool testHostExited)
         {
             // We might consider passing standard output here in case standard error is not
             // available because some errors don't end up in the standard error output.
-            throw new TestPlatformException(string.Format(CrossPlatEngineResources.TestHostExitedWithError, _testHostProcessStdError));
+            throw new TestPlatformException(string.Format(CultureInfo.CurrentCulture, CrossPlatEngineResources.TestHostExitedWithError, _testHostProcessStdError));
         }
     }
 
@@ -478,6 +477,7 @@ private void ThrowExceptionOnConnectionFailure(int connTimeout)
         if (_testHostLaunched)
         {
             errorMsg = string.Format(
+                CultureInfo.CurrentCulture,
                 CommunicationUtilitiesResources.ConnectionTimeoutErrorMessage,
                 CoreUtilitiesConstants.VstestConsoleProcessName,
                 CoreUtilitiesConstants.TesthostProcessName,
@@ -489,9 +489,9 @@ private void ThrowExceptionOnConnectionFailure(int connTimeout)
         if (!StringUtils.IsNullOrWhiteSpace(_testHostProcessStdError))
         {
             // Testhost failed with error.
-            errorMsg = string.Format(CrossPlatEngineResources.TestHostExitedWithError, _testHostProcessStdError);
+            errorMsg = string.Format(CultureInfo.CurrentCulture, CrossPlatEngineResources.TestHostExitedWithError, _testHostProcessStdError);
         }
 
-        throw new TestPlatformException(string.Format(CultureInfo.CurrentUICulture, errorMsg));
+        throw new TestPlatformException(errorMsg);
     }
 }

src/Microsoft.TestPlatform.CrossPlatEngine/Client/TestLoggerManager.cs

@@ -183,10 +183,7 @@ public void Initialize(string? runSettings)
                         : logger.FriendlyName;
 
                 throw new InvalidLoggerException(
-                    string.Format(
-                        CultureInfo.CurrentUICulture,
-                        CommonResources.LoggerNotFound,
-                        value));
+                    string.Format(CultureInfo.CurrentCulture, CommonResources.LoggerNotFound, value));
             }
         }
 
@@ -413,7 +410,7 @@ internal bool TryGetUriFromFriendlyName(string? friendlyName, out Uri? loggerUri
 
                 throw new InvalidLoggerException(
                     string.Format(
-                        CultureInfo.CurrentUICulture,
+                        CultureInfo.CurrentCulture,
                         CommonResources.LoggerUriInvalid,
                         extension.Metadata.ExtensionUri));
             }
@@ -617,7 +614,7 @@ private bool InitializeLogger(object? logger, string? extensionUri, Dictionary<s
             _messageLogger.SendMessage(
                 TestMessageLevel.Error,
                 string.Format(
-                    CultureInfo.CurrentUICulture,
+                    CultureInfo.CurrentCulture,
                     CommonResources.LoggerInitializationError,
                     extensionUri.IsNullOrEmpty() ? "type" : "uri",
                     extensionUri.IsNullOrEmpty() ? logger.GetType().ToString() : extensionUri,

src/Microsoft.TestPlatform.CrossPlatEngine/DataCollection/DotnetDataCollectionLauncher.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.Collections.Generic;
+using System.Globalization;
 using System.IO;
 using System.Reflection;
 
@@ -101,8 +102,7 @@ public override int LaunchDataCollector(IDictionary<string, string?>? environmen
         EqtTrace.Verbose("DotnetDataCollectionLauncher: Full path of dotnet.exe is {0}", currentProcessFileName);
 
         var cliArgs = string.Join(" ", commandLineArguments);
-        var argumentsString = string.Format("{0} \"{1}\" {2} ", args, dataCollectorAssemblyPath, cliArgs);
-
+        var argumentsString = string.Format(CultureInfo.InvariantCulture, "{0} \"{1}\" {2} ", args, dataCollectorAssemblyPath, cliArgs);
         var dataCollectorProcess = _processHelper.LaunchProcess(currentProcessFileName, argumentsString, Directory.GetCurrentDirectory(), environmentVariables, ErrorReceivedCallback, ExitCallBack, null);
 
         DataCollectorProcessId = _processHelper.GetProcessId(dataCollectorProcess);

src/Microsoft.TestPlatform.CrossPlatEngine/DataCollection/ProxyDataCollectionManager.cs

@@ -250,7 +250,7 @@ public void Initialize()
             EqtTrace.Error("ProxyDataCollectionManager.Initialize: failed to connect to datacollector process, processId: {0} port: {1}", _dataCollectionProcessId, _dataCollectionPort);
             throw new TestPlatformException(
                 string.Format(
-                    CultureInfo.CurrentUICulture,
+                    CultureInfo.CurrentCulture,
                     CommunicationUtilitiesResources.ConnectionTimeoutErrorMessage,
                     CoreUtilitiesConstants.VstestConsoleProcessName,
                     CoreUtilitiesConstants.DatacollectorProcessName,
@@ -271,7 +271,7 @@ private int GetConnectionTimeout(int processId)
         {
             ConsoleOutput.Instance.WriteLine(CrossPlatEngineResources.DataCollectorDebuggerWarning, OutputLevel.Warning);
             ConsoleOutput.Instance.WriteLine(
-                string.Format("Process Id: {0}, Name: {1}", processId, _processHelper.GetProcessName(processId)),
+                string.Format(CultureInfo.InvariantCulture, "Process Id: {0}, Name: {1}", processId, _processHelper.GetProcessName(processId)),
                 OutputLevel.Information);
 
             // Increase connection timeout when debugging is enabled.
@@ -307,10 +307,10 @@ private IList<string> GetCommandLineArguments(int portNumber)
         var commandlineArguments = new List<string>
         {
             PortOption,
-            portNumber.ToString(),
+            portNumber.ToString(CultureInfo.CurrentCulture),
 
             ParentProcessIdOption,
-            _processHelper.GetCurrentProcessId().ToString()
+            _processHelper.GetCurrentProcessId().ToString(CultureInfo.CurrentCulture)
         };
 
         if (!StringUtils.IsNullOrEmpty(EqtTrace.LogFile))
@@ -319,7 +319,7 @@ private IList<string> GetCommandLineArguments(int portNumber)
             commandlineArguments.Add(GetTimestampedLogFile(EqtTrace.LogFile));
 
             commandlineArguments.Add(TraceLevelOption);
-            commandlineArguments.Add(((int)EqtTrace.TraceLevel).ToString());
+            commandlineArguments.Add(((int)EqtTrace.TraceLevel).ToString(CultureInfo.CurrentCulture));
         }
 
         return commandlineArguments;
@@ -330,8 +330,9 @@ private static string GetTimestampedLogFile(string logFile)
         return Path.ChangeExtension(
             logFile,
             string.Format(
+                CultureInfo.InvariantCulture,
                 "datacollector.{0}_{1}{2}",
-                DateTime.Now.ToString("yy-MM-dd_HH-mm-ss_fffff"),
+                DateTime.Now.ToString("yy-MM-dd_HH-mm-ss_fffff", CultureInfo.CurrentCulture),
                 new PlatformEnvironment().GetCurrentManagedThreadId(),
                 Path.GetExtension(logFile))).AddDoubleQuote();
     }

src/Microsoft.TestPlatform.CrossPlatEngine/Discovery/DiscovererEnumerator.cs

@@ -232,8 +232,8 @@ private void DiscoverTestsFromSingleDiscoverer(
             // Record Total Tests Discovered By each Discoverer.
             var totalTestsDiscoveredByCurrentDiscoverer = _discoveryResultCache.TotalDiscoveredTests - currentTotalTests;
             _requestData.MetricsCollection.Add(
-                string.Format("{0}.{1}", TelemetryDataConstants.TotalTestsByAdapter,
-                    discoverer.Metadata.DefaultExecutorUri), totalTestsDiscoveredByCurrentDiscoverer);
+                $"{TelemetryDataConstants.TotalTestsByAdapter}.{discoverer.Metadata.DefaultExecutorUri}",
+                totalTestsDiscoveredByCurrentDiscoverer);
 
             totalAdaptersUsed++;
 
@@ -249,14 +249,14 @@ private void DiscoverTestsFromSingleDiscoverer(
 
             // Collecting Data Point for Time Taken to Discover Tests by each Adapter
             _requestData.MetricsCollection.Add(
-                string.Format("{0}.{1}", TelemetryDataConstants.TimeTakenToDiscoverTestsByAnAdapter,
-                    discoverer.Metadata.DefaultExecutorUri), totalAdapterRunTime.TotalSeconds);
+                $"{TelemetryDataConstants.TimeTakenToDiscoverTestsByAnAdapter}.{discoverer.Metadata.DefaultExecutorUri}",
+                totalAdapterRunTime.TotalSeconds);
             totalTimeTakenByAdapters += totalAdapterRunTime.TotalSeconds;
         }
         catch (Exception e)
         {
             var message = string.Format(
-                CultureInfo.CurrentUICulture,
+                CultureInfo.CurrentCulture,
                 CrossPlatEngineResources.ExceptionFromLoadTests,
                 discovererType.Name,
                 e.Message);
@@ -277,10 +277,7 @@ private static bool TryToLoadDiscoverer(LazyExtension<ITestDiscoverer, ITestDisc
         }
         catch (Exception e)
         {
-            var mesage = string.Format(
-                CultureInfo.CurrentUICulture,
-                CrossPlatEngineResources.DiscovererInstantiationException,
-                e.Message);
+            var mesage = string.Format(CultureInfo.CurrentCulture, CrossPlatEngineResources.DiscovererInstantiationException, e.Message);
             logger.SendMessage(TestMessageLevel.Warning, mesage);
             EqtTrace.Error("DiscovererEnumerator.LoadTestsFromAnExtension: {0} ", e);
 
@@ -316,16 +313,13 @@ private static void LogWarningOnNoTestsDiscovered(IEnumerable<string> sources, s
 
             logger.SendMessage(
                 TestMessageLevel.Warning,
-                string.Format(CrossPlatEngineResources.NoTestsAvailableForGivenTestCaseFilter, testCaseFilterToShow, sourcesString));
+                string.Format(CultureInfo.CurrentCulture, CrossPlatEngineResources.NoTestsAvailableForGivenTestCaseFilter, testCaseFilterToShow, sourcesString));
         }
         else
         {
             logger.SendMessage(
                 TestMessageLevel.Warning,
-                string.Format(
-                    CultureInfo.CurrentUICulture,
-                    CrossPlatEngineResources.TestRunFailed_NoDiscovererFound_NoTestsAreAvailableInTheSources,
-                    sourcesString));
+                string.Format(CultureInfo.CurrentCulture, CrossPlatEngineResources.TestRunFailed_NoDiscovererFound_NoTestsAreAvailableInTheSources, sourcesString));
         }
     }
 

src/Microsoft.TestPlatform.CrossPlatEngine/EventHandlers/TestRequestHandler.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Globalization;
 using System.Threading;
 
 using Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.EventHandlers;
@@ -348,7 +349,7 @@ public void OnMessageReceived(object? sender, MessageReceivedEventArgs messageRe
                     // Can only do this after InitializeCommunication because TestHost cannot "Send Log" unless communications are initialized
                     if (!StringUtils.IsNullOrEmpty(EqtTrace.LogFile))
                     {
-                        SendLog(TestMessageLevel.Informational, string.Format(CrossPlatResources.TesthostDiagLogOutputFile, EqtTrace.LogFile));
+                        SendLog(TestMessageLevel.Informational, string.Format(CultureInfo.CurrentCulture, CrossPlatResources.TesthostDiagLogOutputFile, EqtTrace.LogFile));
                     }
                     else if (!StringUtils.IsNullOrEmpty(EqtTrace.ErrorOnInitialization))
                     {