Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parity for AnyCPU containers between .NET Core and .NET FX, add banner with architecture and warning if running emulated(all on win arm64) #3481

Merged
merged 10 commits into from
Mar 18, 2022

Conversation

MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented Mar 17, 2022

  • Add parity in case of AnyCPU container between .NET and .NET Framework, use the current process architecture
  • Add current process architecture to the splash screen
  • Add a warning message in case of running non arm64 version on arm64 version

New behavior for .NET Framework

TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.885, 338241378102, vstest.console.exe, TestRequestManager.RunTests: run tests started.
TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.907, 338241596499, vstest.console.exe, AssemblyMetadataProvider.GetFrameWork: Determined framework:'.NETFramework,Version=v4.7.2' for source: 'C:\Users\xxx\source\repos\UnitTestProject4\UnitTestProject4\bin\Debug\UnitTestProject4.dll'
TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.908, 338241607691, vstest.console.exe, Determined framework for all sources: .NETFramework,Version=v4.7.2
TpTrace Verbose: 0 : 14968, 6, 2022/03/17, 09:44:16.918, 338241706877, vstest.console.exe, TestRequestManager.UpdateRunSettingsIfRequired: Default architecture: ARM64 IsDefaultTargetArchitecture: True, Current process architecture: ARM64 OperatingSystem: Windows.
TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.922, 338241746672, vstest.console.exe, AssemblyMetadataProvider.GetArchitecture: Determined architecture:AnyCPU info for assembly: C:\Users\xxx\source\repos\UnitTestProject4\UnitTestProject4\bin\Debug\UnitTestProject4.dll
TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.922, 338241748322, vstest.console.exe, Determined platform for source 'C:\Users\xxx\source\repos\UnitTestProject4\UnitTestProject4\bin\Debug\UnitTestProject4.dll' is 'AnyCPU'
TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.930, 338241826914, vstest.console.exe, Determined platform for all sources: ARM64
TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.930, 338241832521, vstest.console.exe, Infered platform 'ARM64'.
TpTrace Information: 0 : 14968, 6, 2022/03/17, 09:44:16.931, 338241839171, vstest.console.exe, Platform update to 'ARM64' required.

Banner + warning
image

@MarcoRossignoli MarcoRossignoli changed the title Add parity for AnyCPU containers between .NET Core and .NET FX, add banner with architecture and warning if running emulated on arm64 Add parity for AnyCPU containers between .NET Core and .NET FX, add banner with architecture and warning if running emulated(all on win arm64) Mar 17, 2022
src/vstest.console/CommandLine/Executor.cs Outdated Show resolved Hide resolved
src/vstest.console/Resources/Resources.resx Outdated Show resolved Hide resolved
@nohwnd
Copy link
Member

nohwnd commented Mar 18, 2022

Please also add a unit test test for the new warning. Or maybe there is one and I just overlooked it in the code.

@MarcoRossignoli MarcoRossignoli marked this pull request as ready for review March 18, 2022 08:25
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) March 18, 2022 08:25
@MarcoRossignoli
Copy link
Contributor Author

Please also add a unit test test for the new warning. Or maybe there is one and I just overlooked it in the code.

Done

@MarcoRossignoli MarcoRossignoli merged commit ca9aaa9 into microsoft:main Mar 18, 2022
@MarcoRossignoli MarcoRossignoli deleted the arm64 branch March 18, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants