Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle correctly waiting for process exit on Unix systems #3410

Merged
merged 8 commits into from
Feb 24, 2022
Merged

Handle correctly waiting for process exit on Unix systems #3410

merged 8 commits into from
Feb 24, 2022

Commits on Feb 23, 2022

  1. Add failing test

    @Evangelink
    Evangelink committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    1d9b0a0 View commit details
    Browse the repository at this point in the history

  2. Add exist check for executable path 

    The default failure 'System.ComponentModel.Win32Exception: No such file or directory' is not really helpful to understand what's going-on.
    @Evangelink
    Evangelink committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    b7bc552 View commit details
    Browse the repository at this point in the history

  3. Update failing test

    @Evangelink
    Evangelink committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    e1c0d57 View commit details
    Browse the repository at this point in the history

  4. Fix process WaitForExit logic

    @Evangelink
    Evangelink committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    464f152 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Address review comments

    @Evangelink
    Evangelink committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    09639a9 View commit details
    Browse the repository at this point in the history

  2. Update constant name

    @Evangelink
    Evangelink committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    00ddb0b View commit details
    Browse the repository at this point in the history

  3. Update invalid version used

    @Evangelink
    Evangelink committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f87683d View commit details
    Browse the repository at this point in the history

  4. Address review feedback + update test output

    @Evangelink
    Evangelink committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f90c45c View commit details
    Browse the repository at this point in the history