Apply modern code styles #3264
Merged
Apply modern code styles #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Jan 18, 2022
Evangelink
commented
Jan 18, 2022
nohwnd
reviewed
Jan 18, 2022
test/Microsoft.TestPlatform.TestUtilities/TestPluginCacheHelper.cs
Outdated
Show resolved
Hide resolved
Evangelink
force-pushed
the
allow-latest-csharp-syntax
branch
from
a76f653 to
6fffbd8
Compare
# Conflicts: # scripts/build/TestPlatform.Settings.targets # src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameConstants.cs # src/Microsoft.TestPlatform.AdapterUtilities/TestIdProvider.cs # src/Microsoft.TestPlatform.Common/DataCollection/AfterTestRunEndResult.cs # src/Microsoft.TestPlatform.Common/Filtering/FilterExpression.cs # src/Microsoft.TestPlatform.Common/Logging/InternalTestLoggerEvents.cs # src/Microsoft.TestPlatform.Common/Utilities/FakesUtilities.cs # src/Microsoft.TestPlatform.Common/Utilities/MetadataReaderHelper.cs # src/Microsoft.TestPlatform.CrossPlatEngine/AttachmentsProcessing/DataCollectorAttachmentsProcessorsFactory.cs # src/Microsoft.TestPlatform.CrossPlatEngine/AttachmentsProcessing/TestRunAttachmentsProcessingManager.cs # src/Microsoft.TestPlatform.CrossPlatEngine/Execution/ExecutionManager.cs # src/Microsoft.TestPlatform.ObjectModel/Client/TestSessionInfo.cs # src/Microsoft.TestPlatform.ObjectModel/DataCollector/Attributes/DataCollectorAttachmentProcessor.cs # src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs # src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleProcessManager.cs # src/vstest.console/Publisher/TextFileTelemetryPublisher.cs # test/Microsoft.TestPlatform.AcceptanceTests/AcceptanceTestBase.cs # test/Microsoft.TestPlatform.AcceptanceTests/AppDomainTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/ArgumentProcessorTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/BlameDataCollectorTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/CUITTest.cs # test/Microsoft.TestPlatform.AcceptanceTests/CodeCoverageAcceptanceTestBase.cs # test/Microsoft.TestPlatform.AcceptanceTests/CodeCoverageTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DataCollectionTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DebugAssertTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DeprecateExtensionsPathWarningTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DifferentTestFrameworkSimpleTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DisableAppdomainTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DiscoveryTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DotnetArchitectureSwitchTests.Windows.cs # test/Microsoft.TestPlatform.AcceptanceTests/DotnetArchitectureSwitchTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/DotnetTestTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/EventLogCollectorTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/ExecutionTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/ExecutionThreadApartmentStateTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/FilePatternParserTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/FrameworkTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/ListExtensionsTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/LoggerTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/MultitargetingTestHostTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/PlatformTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/PortableNugetPackageTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/ResultsDirectoryTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/RunsettingsTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/SelfContainedAppTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TelemetryTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TestCaseFilterTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TestPlatformNugetPackageTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/CodeCoverageTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/CustomTestHostTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/DifferentTestFrameworkSimpleTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/DiscoverTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/LiveUnitTestingTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunSelectedTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunTestsWithDifferentConfigurationTests.cs # test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunTestsWithFilterTests.cs # test/Microsoft.TestPlatform.CrossPlatEngine.UnitTests/AttachmentsProcessing/TestRunAttachmentsProcessingManagerTests.cs # test/Microsoft.TestPlatform.SmokeTests/DataCollectorTests.Coverlet.cs # test/Microsoft.TestPlatform.SmokeTests/DotnetHostArchitectureVerifierTests.cs # test/Microsoft.TestPlatform.SmokeTests/ExecutionTests.cs # test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs # test/Microsoft.TestPlatform.TestUtilities/NumberOfProcessLaunchedUtility.cs # test/Microsoft.TestPlatform.TestUtilities/Workspace.cs
# Conflicts: # src/vstest.console/CommandLine/Executor.cs
nohwnd
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to use latest C# syntax across the codebase.
Fix suggestions about (their default severity is and remains as info, let me know if you prefer warning):
Set simplify using rule severity to warning and apply code fix.