AttachVS PR comments fixed #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nohwnd merged 2 commits into microsoft:main from nohwnd:attach-vs-fixes

Nov 29, 2021

Member

nohwnd commented Nov 29, 2021

Fix PR coments from #3197 after it was merged.


          AttachVS PR comments fixed

05cf3c9

nohwnd requested a review from cvpoienaru

November 29, 2021 12:00

nohwnd enabled auto-merge (squash)

November 29, 2021 12:01

Haplois approved these changes

View reviewed changes


          Fix namespace

a506148

cvpoienaru approved these changes

View reviewed changes

Member

cvpoienaru left a comment

LGTM

nohwnd merged commit 9cf8a92 into microsoft:main

Elanis pushed a commit to Elanis/portfolio that referenced this pull request


          Bump Microsoft.NET.Test.Sdk from 17.0.0 to 17.1.0 (#26)

6fce059

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.0.0 to 17.1.0.
<details>
<summary>Release notes</summary>

*Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases).*

> ## v17.1.0
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/main/docs/releases.md#1710).
>
> ## v17.1.0-release-20220113-05
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-release-20220113-05).
>
> ## v17.1.0-preview-20211130-02
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-preview-20211130-02).
>
> ## v17.1.0-preview-20211109-03
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-preview-20211109-03).
</details>
<details>
<summary>Commits</summary>

- [`fcc0e3a`](microsoft/vstest@fcc0e3a) Added support for TestAdapterLoadingStrategy. ([#3374](microsoft/vstest#3374))
- [`d3c6439`](microsoft/vstest@d3c6439) Fix architecture retrival ([#3251](microsoft/vstest#3251))
- [`4d9f0fb`](microsoft/vstest@4d9f0fb) [rel/17.1] Update dependencies from devdiv/DevDiv/vs-code-coverage ([#3221](microsoft/vstest#3221))
- [`d72bcfa`](microsoft/vstest@d72bcfa) [rel/17.1] Update dependencies from devdiv/DevDiv/vs-code-coverage ([#3216](microsoft/vstest#3216))
- [`c9489b4`](microsoft/vstest@c9489b4) External dependencies updated ([#3204](microsoft/vstest#3204))
- [`e90972e`](microsoft/vstest@e90972e) [main] Update dependencies from dotnet/arcade devdiv/DevDiv/vs-code-coverage ...
- [`9cf8a92`](microsoft/vstest@9cf8a92) AttachVS PR comments fixed ([#3201](microsoft/vstest#3201))
- [`8b41e37`](microsoft/vstest@8b41e37) Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...
- [`83de0ad`](microsoft/vstest@83de0ad) Attach to VS automatically ([#3197](microsoft/vstest#3197))
- [`d36b7d8`](microsoft/vstest@d36b7d8) Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...
- Additional commits viewable in [compare view](microsoft/vstest@v17.0.0...v17.1.0)
</details>

<br />

Reviewed-on: https://gitea.dysnomia.studio/elanis/portfolio/pulls/26
Co-authored-by: elanis <elanis@noreply.example.org>
Co-committed-by: elanis <elanis@noreply.example.org>

Elanis pushed a commit to Dysnomia-Studio/dehash-me that referenced this pull request


          Bump Microsoft.NET.Test.Sdk from 17.0.0 to 17.1.0 (#38)

71bbd2a

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.0.0 to 17.1.0.
<details>
<summary>Release notes</summary>

*Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases).*

> ## v17.1.0
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/main/docs/releases.md#1710).
>
> ## v17.1.0-release-20220113-05
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-release-20220113-05).
>
> ## v17.1.0-preview-20211130-02
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-preview-20211130-02).
>
> ## v17.1.0-preview-20211109-03
> See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-preview-20211109-03).
</details>
<details>
<summary>Commits</summary>

- [`fcc0e3a`](microsoft/vstest@fcc0e3a) Added support for TestAdapterLoadingStrategy. ([#3374](microsoft/vstest#3374))
- [`d3c6439`](microsoft/vstest@d3c6439) Fix architecture retrival ([#3251](microsoft/vstest#3251))
- [`4d9f0fb`](microsoft/vstest@4d9f0fb) [rel/17.1] Update dependencies from devdiv/DevDiv/vs-code-coverage ([#3221](microsoft/vstest#3221))
- [`d72bcfa`](microsoft/vstest@d72bcfa) [rel/17.1] Update dependencies from devdiv/DevDiv/vs-code-coverage ([#3216](microsoft/vstest#3216))
- [`c9489b4`](microsoft/vstest@c9489b4) External dependencies updated ([#3204](microsoft/vstest#3204))
- [`e90972e`](microsoft/vstest@e90972e) [main] Update dependencies from dotnet/arcade devdiv/DevDiv/vs-code-coverage ...
- [`9cf8a92`](microsoft/vstest@9cf8a92) AttachVS PR comments fixed ([#3201](microsoft/vstest#3201))
- [`8b41e37`](microsoft/vstest@8b41e37) Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...
- [`83de0ad`](microsoft/vstest@83de0ad) Attach to VS automatically ([#3197](microsoft/vstest#3197))
- [`d36b7d8`](microsoft/vstest@d36b7d8) Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...
- Additional commits viewable in [compare view](microsoft/vstest@v17.0.0...v17.1.0)
</details>

<br />

Reviewed-on: https://gitea.dysnomia.studio/elanis/dehash-me/pulls/38
Co-authored-by: elanis <elanis@noreply.example.org>
Co-committed-by: elanis <elanis@noreply.example.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet