-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for spaces and other special characters in method names into the ManagedNameUtilities #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Haplois
commented
Feb 7, 2021
•
edited
Loading
edited
- Fixes ManagedNameUtilities does not support spaces and other special characters in method names #2733
- Fixes AB#1274433
Haplois
force-pushed
the
fqn-refactoring
branch
3 times, most recently
from
February 9, 2021 03:40
6f17937
to
d8b2108
Compare
Haplois
force-pushed
the
fqn-refactoring
branch
from
February 9, 2021 12:45
d8b2108
to
4a49ba3
Compare
Haplois
force-pushed
the
fqn-refactoring
branch
from
February 15, 2021 10:13
5184413
to
2e32815
Compare
Haplois
force-pushed
the
fqn-refactoring
branch
from
February 15, 2021 10:15
2e32815
to
a57d5ac
Compare
nohwnd
reviewed
Feb 15, 2021
cvpoienaru
suggested changes
Feb 15, 2021
src/Microsoft.TestPlatform.AdapterUtilities/Helpers/ReflectionHelpers.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/Helpers/ReflectionHelpers.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/Helpers/ReflectionHelpers.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/Helpers/ReflectionHelpers.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/Helpers/ReflectionHelpers.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameParser.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameParser.cs
Show resolved
Hide resolved
...ft.TestPlatform.AdapterUtilities.UnitTests/ManagedNameUtilities/ManagedNameRoundTripTests.cs
Outdated
Show resolved
Hide resolved
...ft.TestPlatform.AdapterUtilities.UnitTests/ManagedNameUtilities/ManagedNameRoundTripTests.cs
Outdated
Show resolved
Hide resolved
...ft.TestPlatform.AdapterUtilities.UnitTests/ManagedNameUtilities/ManagedNameRoundTripTests.cs
Outdated
Show resolved
Hide resolved
cvpoienaru
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.