Dumping child processes #2518
Merged
Dumping child processes #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
Aug 13, 2020
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcessCodeMethods.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
Aug 13, 2020
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcessCodeMethods.cs
Show resolved
Hide resolved
Sanan07
reviewed
Aug 13, 2020
Comment on lines
+75
to
+86
| foreach (var p in bottomUpTree) | ||
| { | ||
| try | ||
| { | ||
| EqtTrace.Verbose($"NetClientHangDumper.Dump: Killing process {p.Id} - {p.ProcessName}."); | ||
| p.Kill(); | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| EqtTrace.Error($"NetClientHangDumper.Dump: Error killing process {p.Id} - {p.ProcessName}: {ex}."); | ||
| } | ||
| } |
There was a problem hiding this comment.
Would not be better to place it in separate method? Or can we combine all three for-each loops in one and execute methods in chain? Will that work?
There was a problem hiding this comment.
Refactor for better refactoring?
There was a problem hiding this comment.
To have better refactored code.
There was a problem hiding this comment.
Yes, but how adding a method helps the code to be better? It invokes a single method in between logging. This imho reads okay, and the log will be easier to parse. - Will adding a method outweight this benefit?
Sanan07
reviewed
Aug 13, 2020
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/NetClientHangDumper.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcessCodeMethods.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcessCodeMethods.cs
Outdated
Show resolved
Hide resolved
Haplois
approved these changes
Aug 13, 2020
|
Hello @nohwnd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow child processes to be crash and hang dumped on Windows, MacOS and Linux. Dumps are by default generated to %TEMP%\guid and all generated dumps are collected from that folder. Unlike before where we told the tool the exact path for the dump and then looked just for that file.
Related issue
#2498