Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TRX file overwrite in certain circumstances #2508

Merged
16 commits merged into from
Aug 7, 2020
Merged

Fixed TRX file overwrite in certain circumstances #2508

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d8e103c
Initial fixes.
Haplois Aug 4, 2020
8a7817d
PR recommendations fixed..
Haplois Aug 4, 2020
651c6e9
PR recommendations fixed..
Haplois Aug 4, 2020
6c7ea2a
PR recommendations fixed.. v3
Haplois Aug 4, 2020
b56a5e9
Removed Mutex from TrxLogger
Haplois Aug 5, 2020
0f17d0a
Merge remote-tracking branch 'upstream/master' into fix/dotnet-test-o…
Haplois Aug 6, 2020
09dfc16
Modified the internal file helper use a DateTime provider func for te…
Haplois Aug 7, 2020
c67c602
Refactored some tests.
Haplois Aug 7, 2020
3cda397
Update TrxLoggerTests.cs
Haplois Aug 7, 2020
d43f24f
Update TrxLoggerTests.cs
Haplois Aug 7, 2020
6f4c66e
Renamed InternalFileHelper to TrxFileHelper
Haplois Aug 7, 2020
c34fc76
Update and rename FileHelperTests.cs to TrxFileHelperTests.cs
Haplois Aug 7, 2020
8b0483d
Update TrxLoggerTests.cs
Haplois Aug 7, 2020
189742d
Updated TrxLoggerTests for clarity
Haplois Aug 7, 2020
9b86ab9
Merge branch 'fix/dotnet-test-overwrite-2489' of https://github.com/H…
Haplois Aug 7, 2020
7c1e0fe
Update TrxLoggerTests.cs
Haplois Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update TrxLoggerTests.cs 
Added the reason why we need to keep a specific pattern in TRX file naming.
  • Loading branch information
@Haplois
Haplois committed Aug 7, 2020
commit 3cda3977821b31abc24dcd553228fe5b4228cca6
2 changes: 1 addition & 1 deletion test/Microsoft.TestPlatform.Extensions.TrxLogger.UnitTests/TrxLoggerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ public void DefaultTrxFileNameVerification()
var fileName = Path.GetFileName(testableTrxLogger.trxFile);
var expectedName = $"{DefaultLogFilePrefixParameterValue}{time:_yyyyMMddHHmmss}.trx";

Assert.AreEqual(expectedName, fileName, "Trx file name pattern has changed. It should be in the form of prefix_yyyyMMddHHmmss.trx");
Assert.AreEqual(expectedName, fileName, "Trx file name pattern has changed. It should be in the form of prefix_yyyyMMddHHmmss.trx, Azure Devops VSTest task depends on this naming.");
}

[TestMethod]
Expand Down