Nuget.Frameworks renamed netcoreapp5.0 to net5.0 #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvpoienaru
approved these changes
Jul 24, 2020
wli3
reviewed
Jul 27, 2020
| @@ -81,7 +81,8 @@ public static string GenerateFakesSettingsForRunConfiguration(string[] sources, | |||
| // Since there are no FrameworkVersion values for .Net Core 2.0 +, we check TargetFramework instead | |||
| // and default to FrameworkCore10 for .Net Core | |||
| if (targetFramework.Name.IndexOf("netstandard", StringComparison.OrdinalIgnoreCase) >= 0 || | |||
| targetFramework.Name.IndexOf("netcoreapp", StringComparison.OrdinalIgnoreCase) >= 0) | |||
| targetFramework.Name.IndexOf("netcoreapp", StringComparison.OrdinalIgnoreCase) >= 0 || | |||
There was a problem hiding this comment.
Will that work after net5? @zkat there is a better way to do it right?
There was a problem hiding this comment.
This won't work after net5, and I am sure there is a better way to do this, but this one was the fastest and safest way to get the fix out without running into potential conflicts with matching ".NETFramework" moniker in unintended places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.