Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the parameters to VSTestTask to allow dotnet test to work #2438

Merged
2 commits merged into from
May 15, 2020

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented May 15, 2020

Description

Please add a meaningful description for this change.
Add parameters for Blame dump options that dotnet test will use to pass the parameters to vstest console.

@ghost
Copy link

ghost commented May 15, 2020

Hello @nohwnd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 3 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@Sanan07 Sanan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my thought about some parts of code, others look good to me :)

Copy link
Contributor

@Sanan07 Sanan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ghost ghost merged commit 59354e1 into microsoft:master May 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants