Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More verbose info in datacollector log #2430

Merged
1 commit merged into from
May 11, 2020
Merged

More verbose info in datacollector log #2430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CommunicationUtilities/DataCollectionTestCaseEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public void ProcessRequests()

if (EqtTrace.IsInfoEnabled)
{
EqtTrace.Info("DataCollectionTestCaseEventHandler: Test case started.");
EqtTrace.Info("DataCollectionTestCaseEventHandler: Test case '{0} - {1}' started.", testCaseStartEventArgs.TestCaseName, testCaseStartEventArgs.TestCaseId);
}

break;
Expand All @@ -101,7 +101,7 @@ public void ProcessRequests()

if (EqtTrace.IsInfoEnabled)
{
EqtTrace.Info("DataCollectionTestCaseEventHandler: Test case completed");
EqtTrace.Info("DataCollectionTestCaseEventHandler: Test case '{0} - {1}' completed", testCaseEndEventArgs.TestCaseName, testCaseEndEventArgs.TestCaseId);
}

break;
Expand All @@ -121,7 +121,7 @@ public void ProcessRequests()
default:
if (EqtTrace.IsInfoEnabled)
{
EqtTrace.Info("DataCollectionTestCaseEventHandler: Invalid Message types");
EqtTrace.Info("DataCollectionTestCaseEventHandler: Invalid Message type '{0}'", message.MessageType);
}

break;
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Execution/TestRunCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ public bool OnTestCompletion(TestCase completedTest)

if (this.inProgressTests == null || this.inProgressTests.Count == 0)
{
EqtTrace.Warning("InProgressTests is null");
EqtTrace.Warning("TestRunCache: InProgressTests is null");
return false;
}

Expand Down Expand Up @@ -394,7 +394,7 @@ private void RemoveInProgress(TestResult result)
var removed = this.OnTestCompletion(result.TestCase);
if (!removed)
{
EqtTrace.Warning("TestRunCache: No test found corresponding to testResult '{0}' in inProgress list.", result);
EqtTrace.Warning("TestRunCache: No test found corresponding to testResult '{0}' in inProgress list.", result.DisplayName);
}
}

Expand Down