Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap error message/stack trace content in <pre> #2419

Merged
2 commits merged into from
Apr 29, 2020

Conversation

RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Apr 23, 2020

Description

This enhances the readability of error messages and stack traces in HTML logs by wrapping the content in the <pre> tag.

Here's a side-by-side comparison, where the first test failure shown has no <pre> tags and the second test failure does have <pre> tags.

image

Related issue

Closes #2414

@ghost
Copy link

ghost commented Apr 29, 2020

Hello @nohwnd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@nohwnd nohwnd added this to the 16.7.0 milestone Apr 29, 2020
Copy link
Member

@pavelhorak pavelhorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps easier was modifying line 68 like: .error-stack-trace { color: brown; white-space: pre; }

@ghost ghost merged commit df61f73 into microsoft:master Apr 29, 2020
@RikkiGibson RikkiGibson deleted the patch-1 branch April 29, 2020 18:54
@RikkiGibson
Copy link
Member Author

Thank you!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML logger should honor line breaks in stack traces
3 participants