Fix splitting of test name from fully qualified name #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
Mar 4, 2020
| } | ||
|
|
||
| [TestMethod] | ||
| public void ToTestElementShouldContainExpectedTestMethodPropertiesIfFqnDoesNotEndsWithTestName() | ||
| { | ||
| var expectedClassName = "TestProject1.Class1.TestMethod1(2, 3, 4"; | ||
| var fullyQualifiedName = "TestProject1.Class1.TestMethod1(2, 3, 4.0d)"; | ||
| var expectedTestName = "0d)"; |
There was a problem hiding this comment.
@singhsarab I moved the test data to be more explicit, because the helper method ValidateTestMethodProperties was re- implementing the same code in the test and in the source, and both of them had the same bug. The current behavior is explicitly stating the same thing that it did before I refactored. It splits on the decimal point in 4.0d, which I assume is not correct. What would be the correct behavior here?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jakubch1
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a meaningful description for this change.
Ensure the PR has required unit tests.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.