Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverlet smoke test #2348

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Conversation

MarcoRossignoli
Copy link
Contributor

Replacement of #2330

cc: @nohwnd

@MarcoRossignoli
Copy link
Contributor Author

Will run

C:\git\vstest\tools\dotnet\dotnet.exe "C:\git\vstest\artifacts\Debug\netcoreapp2.1\vstest.console.dll" --collect:"XPlat Code Coverage" "C:\git\vstest\test\TestAssets\CoverletCoverageTestProject\bin\Debug\netcoreapp2.1\CoverletCoverageTestProject.dll" /testadapterpath:"C:\git\vstest\packages\coverlet.collector\1.2.0\build\netstandard1.0" /logger:"console;verbosity=normal" --diag:"C:\git\vstest\test\TestAssets\CoverletCoverageTestProject\bin\Debug\netcoreapp2.1\coverletcoverage.c1576706e089454c88afe389423d31e6.log"

@nohwnd
Copy link
Member

nohwnd commented Mar 2, 2020

PR is just a pointer to a branch. You could just update the previous PR by pushing into it’s branch (even rebasing and force pushing if needed. Well next time ☺️

@MarcoRossignoli
Copy link
Contributor Author

PR is just a pointer to a branch. You could just update the previous PR by pushing into it’s branch (even rebasing and force pushing if needed. Well next time ☺️

I know, #2330 (comment) as explained here I tried to rebase and resolve conflicts a pair of time with no luck(repo build error due to issue on sln guids) your update was a bit invasive 😄 on project structure, so to not waste too much time I created a new one since my update are few code lines.

@nohwnd
Copy link
Member

nohwnd commented Mar 2, 2020 via email

@MarcoRossignoli
Copy link
Contributor Author

Thanks advices are always well accepted!

@nohwnd nohwnd merged commit 2e97a20 into microsoft:master Mar 9, 2020
@MarcoRossignoli MarcoRossignoli deleted the coverletsmoketest branch March 9, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants