DataCollector check with only Uri in Runsettings #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Sep 17, 2019
src/Microsoft.TestPlatform.CrossPlatEngine/DataCollection/DataCollectionLauncherFactory.cs
Outdated
Show resolved
Hide resolved
singhsarab
reviewed
Sep 18, 2019
src/Microsoft.TestPlatform.Common/DataCollection/DataCollectionManager.cs
Outdated
Show resolved
Hide resolved
singhsarab
reviewed
Sep 18, 2019
src/Microsoft.TestPlatform.Common/DataCollection/DataCollectionManager.cs
Outdated
Show resolved
Hide resolved
singhsarab
reviewed
Sep 18, 2019
src/Microsoft.TestPlatform.Common/Resources/xlf/Resources.cs.xlf
Outdated
Show resolved
Hide resolved
|
@hvinett Can you please resolve the comments and complete this one first. |
singhsarab
reviewed
Sep 27, 2019
src/Microsoft.TestPlatform.Common/DataCollection/DataCollectionManager.cs
Show resolved
Hide resolved
singhsarab
reviewed
Oct 1, 2019
| @@ -43,7 +43,12 @@ public DataCollectionManagerTests() | |||
|
|
|||
| this.dataCollectorSettings = string.Format(this.defaultRunSettings, string.Format(this.defaultDataCollectionSettings, friendlyName, uri, this.mockDataCollector.Object.GetType().AssemblyQualifiedName, typeof(DataCollectionManagerTests).GetTypeInfo().Assembly.Location, string.Empty)); | |||
| this.dataCollectorSettingsWithWrongFriendlyName = string.Format(this.defaultRunSettings, string.Format(this.defaultDataCollectionSettings, "anyFriendlyName", uri, this.mockDataCollector.Object.GetType().AssemblyQualifiedName, typeof(DataCollectionManagerTests).GetTypeInfo().Assembly.Location, string.Empty)); | |||
| this.dataCollectorSettingsWithoutFriendlyName = string.Format(this.defaultRunSettings, string.Format(this.defaultDataCollectionSettings, string.Empty, uri, this.mockDataCollector.Object.GetType().AssemblyQualifiedName, typeof(DataCollectionManagerTests).GetTypeInfo().Assembly.Location, string.Empty).Replace("friendlyName=\"\"", string.Empty)); | |||
| this.dataCollectorSettingsWithWrongUri = string.Format(this.defaultRunSettings, string.Format(this.defaultDataCollectionSettings, friendlyName, "my://custom/WrongDatacollector", this.mockDataCollector.Object.GetType().AssemblyQualifiedName, typeof(DataCollectionManagerTests).GetTypeInfo().Assembly.Location, string.Empty)); | |||
There was a problem hiding this comment.
this.dataCollectorSettingsWithWrongUri [](start = 12, length = 39)
Why do these have to be a member variable?
added 3 commits
October 1, 2019 17:02
singhsarab
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removing friendly name check when only Uri is given in run settings
If Uri is correct it proceeds with Uri otherwise if friendly name is correct we get the first uri with that friendly name and proceeds with it. In rest of the cases it shows error.
Related issue
#1952
Behavior