Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestRunRequestEventsRegistrar null in run specific tests #2051

Merged

Conversation

vagisha-nidhi
Copy link
Contributor

@vagisha-nidhi vagisha-nidhi commented Jun 11, 2019

Description

Test run events registrar is null in case of run selected scenario causing the following error:

Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
Microsoft.VisualStudio.TestPlatform.CommandLine.TestPlatformHelpers.TestRequestManager.CheckSourcesForCompatibility(Framework chosenFramework, Architecture chosenPlatform, IDictionary`2 sourcePlatforms, IDictionary`2 sourceFrameworks, IBaseTestEventsRegistrar registrar)
Microsoft.VisualStudio.TestPlatform.CommandLine.TestPlatformHelpers.TestRequestManager.UpdateRunSettingsIfRequired(String runsettingsXml, List`1 sources, IBaseTestEventsRegistrar registrar, String& updatedRunSettingsXml)
Microsoft.VisualStudio.TestPlatform.CommandLine.TestPlatformHelpers.TestRequestManager.RunTests(TestRunRequestPayload testRunRequestPayload, ITestHostLauncher testHostLauncher, ITestRunEventsRegistrar testRunEventsRegistrar, ProtocolConfig protocolConfig)
Microsoft.VisualStudio.TestPlatform.CommandLine.Processors.RunSpecificTestsArgumentExecutor.ExecuteSelectedTests()
Microsoft.VisualStudio.TestPlatform.CommandLine.Processors.RunSpecificTestsArgumentExecutor.Execute()
Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.ExecuteArgumentProcessor(IArgumentProcessor processor, Int32& exitCode)
Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.Execute(String[] args)
Microsoft.VisualStudio.TestPlatform.CommandLine.Program.Main(String[] args)

/// </summary>
/// <param name="sender"></param>
/// <param name="e">RunCompletion args</param>
private void TestRunRequest_OnRunCompletion(object sender, TestRunCompleteEventArgs e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test this please

@vagisha-nidhi vagisha-nidhi merged commit 29fc1d1 into microsoft:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants