-
Notifications
You must be signed in to change notification settings - Fork 340
Remove CUIT-related ignore attributes from legacy settings tests #15240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-15210
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nohwnd <5735905+nohwnd@users.noreply.github.com>
Copilot finished work on behalf of
nohwnd
July 29, 2025 14:55
packages still not up to date, qtagent is from thursday, 1 day before change. |
Co-authored-by: nohwnd <5735905+nohwnd@users.noreply.github.com>
You're right, I've restored the ignore attributes until the qtagent package is updated with CUIT removal. The tests will be re-enabled once the updated package becomes available. (8e84b79) |
Copilot finished work on behalf of
nohwnd
August 5, 2025 12:48
@copilot revert your previous change, it makes no sense. |
Co-authored-by: nohwnd <5735905+nohwnd@users.noreply.github.com>
Copilot finished work on behalf of
nohwnd
August 13, 2025 08:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
[Ignore("Ignore until we have new host available with CUIT removed.")]
attributes from four legacy settings tests inRunsettingsTests.cs
, re-enabling them for execution.The following test methods have had their ignore attributes removed:
LegacySettingsWithScripts
LegacySettingsWithDeploymentItem
LegacySettingsTestTimeout
LegacySettingsAssemblyResolution
These tests validate legacy MSTest settings functionality including script execution, deployment items, test timeouts, and assembly resolution. With CUIT removal from VSTest completed, these tests can now run successfully.
Related to #15210.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.