Fixed review comments for PR #3728 (#3882)

microsoft · Jul 22, 2022 · 1153731 · 1153731
1 parent 166cf16
commit 1153731
Show file tree

Hide file tree

Showing 18 changed files with 90 additions and 8 deletions.
diff --git a/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs b/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
@@ -193,8 +193,8 @@ public virtual TestProcessStartInfo GetTestHostProcessStartInfo(
         var processName = _processHelper.GetCurrentProcessFileName();
         if (processName is not null)
         {
-            if (!_environment.OperatingSystem.Equals(PlatformOperatingSystem.Windows) &&
-                !processName.EndsWith(DotnetHostHelper.MONOEXENAME, StringComparison.OrdinalIgnoreCase))
+            if (!_environment.OperatingSystem.Equals(PlatformOperatingSystem.Windows)
+                && !processName.EndsWith(DotnetHostHelper.MONOEXENAME, StringComparison.OrdinalIgnoreCase))
             {
                 launcherPath = _dotnetHostHelper.GetMonoPath();
                 argumentsString = testhostProcessPath.AddDoubleQuote() + " " + argumentsString;

diff --git a/src/vstest.console/InProcessVsTestConsoleWrapper.cs b/src/vstest.console/InProcessVsTestConsoleWrapper.cs
@@ -77,7 +77,7 @@ internal InProcessVsTestConsoleWrapper(
         {
             // Close the sender as it failed to host server.
             _requestSender.Close();
-            throw new TransationLayerException("Error hosting communication channel.");
+            throw new TransationLayerException(Resources.Resources.ErrorHostingCommunicationChannel);
         }
 
         // Fill the parameters.
@@ -119,9 +119,9 @@ internal InProcessVsTestConsoleWrapper(
         if (TestRequestManager is null)
         {
             TPDebug.Assert(
-                (DesignModeClient?)DesignModeClient.Instance != null,
+                DesignModeClient.Instance != null,
                 "DesignModeClient.Instance is null");
-            TestRequestManager = ((DesignModeClient)DesignModeClient.Instance).TestRequestManager;
+            TestRequestManager = DesignModeClient.Instance.TestRequestManager;
         }
 
         _testPlatformEventSource.TranslationLayerInitializeStop();
@@ -476,7 +476,7 @@ public void RunTests(
 
             var testRunPayload = new TestRunRequestPayload
             {
-                Sources = sourceList.ToList(),
+                Sources = sourceList,
                 RunSettings = runSettings,
                 TestPlatformOptions = options,
                 TestSessionInfo = testSessionInfo
@@ -637,7 +637,7 @@ testSessionInfo is null
             {
                 Sources = sourceList,
                 RunSettings = runSettings,
-                DebuggingEnabled = (customLauncher?.IsDebug == true),
+                DebuggingEnabled = customLauncher?.IsDebug == true,
                 TestPlatformOptions = options,
                 TestSessionInfo = testSessionInfo
             };

diff --git a/src/vstest.console/Resources/Resources.Designer.cs b/src/vstest.console/Resources/Resources.Designer.cs
diff --git a/src/vstest.console/Resources/Resources.resx b/src/vstest.console/Resources/Resources.resx
@@ -819,4 +819,7 @@
   <data name="StopTestSessionTimedOut" xml:space="preserve">
     <value>Waiting for stop test session timed out after {0} seconds.</value>
   </data>
-</root>
+  <data name="ErrorHostingCommunicationChannel" xml:space="preserve">
+    <value>Error hosting communication channel.</value>
+  </data>
+</root>
diff --git a/src/vstest.console/Resources/xlf/Resources.cs.xlf b/src/vstest.console/Resources/xlf/Resources.cs.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.de.xlf b/src/vstest.console/Resources/xlf/Resources.de.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.es.xlf b/src/vstest.console/Resources/xlf/Resources.es.xlf
@@ -1197,6 +1197,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.fr.xlf b/src/vstest.console/Resources/xlf/Resources.fr.xlf
@@ -1194,6 +1194,11 @@ Comportements actuellement pris en charge :
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.it.xlf b/src/vstest.console/Resources/xlf/Resources.it.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.ja.xlf b/src/vstest.console/Resources/xlf/Resources.ja.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.ko.xlf b/src/vstest.console/Resources/xlf/Resources.ko.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.pl.xlf b/src/vstest.console/Resources/xlf/Resources.pl.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.pt-BR.xlf b/src/vstest.console/Resources/xlf/Resources.pt-BR.xlf
@@ -1194,6 +1194,11 @@ Altere o prefixo de nível de diagnóstico do agente de console, como mostrado a
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.ru.xlf b/src/vstest.console/Resources/xlf/Resources.ru.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.tr.xlf b/src/vstest.console/Resources/xlf/Resources.tr.xlf
@@ -1194,6 +1194,11 @@ Günlükler için izleme düzeyini aşağıda gösterildiği gibi değiştirin
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.xlf b/src/vstest.console/Resources/xlf/Resources.xlf
@@ -988,6 +988,11 @@ Format : TestRunParameters.Parameter(name="&lt;name&gt;", value="&lt;value&gt;")
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.zh-Hans.xlf b/src/vstest.console/Resources/xlf/Resources.zh-Hans.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/vstest.console/Resources/xlf/Resources.zh-Hant.xlf b/src/vstest.console/Resources/xlf/Resources.zh-Hant.xlf
@@ -1194,6 +1194,11 @@
         <target state="new">Waiting for stop test session timed out after {0} seconds.</target>
         <note></note>
       </trans-unit>
+      <trans-unit id="ErrorHostingCommunicationChannel">
+        <source>Error hosting communication channel.</source>
+        <target state="new">Error hosting communication channel.</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>