Allow table specific tags for markdown in hovers (fixes #99983) #99988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe a candidate for recovery build? |
alexr00
approved these changes
Jun 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #99983
#97793 added list of
allowedTagsthat's based on Commonmark spec.Tables come from GitHub Flavored Markdown and were mentioned in GH spec only and therefore
thead, andtbodywere stripped from output leaving empty space.Only tag that's produced by GHFM and not in list is
checkbox, so I didn't add it to the list.It looks like #97793 had no tests specific to that change. Do I need to add tests for tables in scope of this PR?
/cc @mjbvz @alexr00