Force custom editors wrapper element in diff view to have 100% height#96969
Merged
mjbvz merged 1 commit intomicrosoft:release/1.45from May 5, 2020
Merged
Force custom editors wrapper element in diff view to have 100% height#96969mjbvz merged 1 commit intomicrosoft:release/1.45from
mjbvz merged 1 commit intomicrosoft:release/1.45from
Conversation
Fix for microsoft#96968 This is a scoped fix for microsoft#96968. The cause of the issue is the following: 1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM. 1. In split views, we try to lay the webview out over an element that has 0 height. 1. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but I've scoped my fix to just webviews
mjbvz
force-pushed
the
fix-webview-diff-145
branch
from
57c4158 to
3778525
Compare
sbatten
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #96968
This is a scoped fix for #96968.
The cause of the issue is the following:
This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but to play it safe I've scoped my fix to just webviews with this change