Skip to content

Add support of relative paths for git.ignoredRepositories #83466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2019

Conversation

Wowol
Copy link
Contributor

@Wowol Wowol commented Oct 28, 2019

This PR fixes #76892

@joaomoreno joaomoreno added the git GIT issues label Oct 29, 2019
@Wowol Wowol force-pushed the issue-76892 branch 2 times, most recently from 3a51078 to a7c73af Compare October 29, 2019 22:15
@Wowol
Copy link
Contributor Author

Wowol commented Oct 29, 2019

@joaomoreno You were right, converting the path into a URI and then getting its fsPath is breaking path on Linux, so I've removed it. Pull request is ready to be merged now :)

@Wowol
Copy link
Contributor Author

Wowol commented Nov 14, 2019

@joaomoreno Is there anything wrong with this PR? I'm not sure why it isn't merged yet, and I don't want conflicts to appear in future due to further changes.
If I can help with something, please let me know.

@joaomoreno
Copy link
Member

Thanks! 🎆

@joaomoreno joaomoreno merged commit 0fb5275 into microsoft:master Nov 29, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of relative paths for git.ignoredRepositories
2 participants