Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt icon font in explorer #81350

Merged
merged 12 commits into from
Sep 24, 2019
Merged

Adopt icon font in explorer #81350

merged 12 commits into from
Sep 24, 2019

Conversation

miguelsolorio
Copy link
Contributor

Related #78889

This adopts the icon font in the explorer and some editor tabs:

image

These icons also use icon.foreground and when configured will look like:

image

I've gone through and tested the various cases (multiple editor groups + hover/dirty states, etc.) and would love it if you could give it a quick pass to ensure I didn't miss any icons. Note that I haven't done the tree chevrons and other editor toolbar items (like when tab visibility is toggled off).

@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Sep 24, 2019
@bpasero bpasero requested a review from isidorn September 24, 2019 06:44
@bpasero bpasero removed their assignment Sep 24, 2019
@bpasero
Copy link
Member

bpasero commented Sep 24, 2019

Adding @isidorn for explorer.

@isidorn
Copy link
Contributor

isidorn commented Sep 24, 2019

@misolori nice work. Especially like how we are getting rid of css.
I have tested this out and verified this works nicely out of source and by doing a full local build of vscode -> approved.

@miguelsolorio miguelsolorio merged commit 841b336 into master Sep 24, 2019
@miguelsolorio miguelsolorio deleted the misolori/icon-font-explorer branch September 24, 2019 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
icons-product Issues for in-product icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants