-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt icon font in explorer #81350
Merged
Merged
Adopt icon font in explorer #81350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding @isidorn for explorer. |
bpasero
approved these changes
Sep 24, 2019
@misolori nice work. Especially like how we are getting rid of |
isidorn
approved these changes
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #78889
This adopts the icon font in the explorer and some editor tabs:
These icons also use
icon.foreground
and when configured will look like:I've gone through and tested the various cases (multiple editor groups + hover/dirty states, etc.) and would love it if you could give it a quick pass to ensure I didn't miss any icons. Note that I haven't done the tree chevrons and other editor toolbar items (like when tab visibility is toggled off).