Skip to content

fix #72187 #72194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2019
Merged

fix #72187 #72194

merged 2 commits into from
Apr 12, 2019

Conversation

LeuisKen
Copy link
Contributor

@LeuisKen LeuisKen commented Apr 12, 2019

There is two way to fix this issue, and because I think this bug is caused by mistake, so I just revert the implements.

And I think the case needs a test to cover, but I didn't find vscode.openFolder test, I'll really appreciate if someone can teach me how to do this.

Thanks. : )

@aeschli
Copy link
Contributor

aeschli commented Apr 12, 2019

@LeuisKen Thanks for helping. I'd suggest to make the fix in apiCommands.

Change-Id: Id4d6a14865fb1631b969d84f05bdfa655f5c7235
@aeschli aeschli self-assigned this Apr 12, 2019
@aeschli aeschli added this to the April 2019 milestone Apr 12, 2019
Change-Id: I25f92e400ef2f999d604e5ca97637145142de1a1
@aeschli
Copy link
Contributor

aeschli commented Apr 12, 2019

Looks good, thanks!

@aeschli aeschli merged commit 9077e2c into microsoft:master Apr 12, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants