Display extensionId as the description in the formatter dropdown #71910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs to be tested against the case where the formatter is included by default with VSCode (or would that still be considered an extension and therefore return an |
Sure, all extensions are equal |
jrieken
requested changes
Apr 9, 2019
| @@ -127,7 +127,8 @@ class DefaultFormatter extends Disposable implements IWorkbenchContribution { | |||
| const picks = formatter.map((formatter, index) => { | |||
| return <IIndexedPick>{ | |||
| index, | |||
| label: formatter.displayName || formatter.extensionId || '?' | |||
| label: formatter.displayName || formatter.extensionId || '?', | |||
| description: formatter.extensionId!.value | |||
There was a problem hiding this comment.
Maybe better description: formatter.extensionId && formatter.extensionId.value A formatter should always have an extension id but must not have one...
There was a problem hiding this comment.
I just kind of assumed the !. TypeScript operator worked like &. in Ruby, it seems like this is a better equivalent for &. anyway.
jrieken
approved these changes
Apr 10, 2019
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I wasn't able to figure out how to get a locally compiled version of Code working, so I wasn't able to test that this change does what I want.Resolves #71904
Now displays the extension ID next to the formatter's
displayName(there are supposed to be two formatters here, that's an unrelated thing with the extension I'm using to test this):