Skip to content

FindInFiles converted to command and accepting arguments #71626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

jwikman
Copy link
Contributor

@jwikman jwikman commented Apr 3, 2019

Tries to solve #29405

@msftclas
Copy link

msftclas commented Apr 3, 2019

CLA assistant check
All CLA requirements met.

@jwikman
Copy link
Contributor Author

jwikman commented Apr 3, 2019

@roblourens - Code is modified to use an args variable when calling setSearchParameters (which is renamed)

Did you get a few minutes to think about the trigger search parameter?

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this, but I am going to keep thinking about triggerSearch, and I reserve the right to revert it before the next stable release :)

Thanks for the PR!

@roblourens roblourens merged commit 6d444df into microsoft:master Apr 8, 2019
@roblourens
Copy link
Member

Btw, thinking about it more, I think all of this is fine, including allowing an extension to trigger the search, and I look forward to seeing what people use it for!

@jwikman
Copy link
Contributor Author

jwikman commented Apr 12, 2019

Thanks @roblourens, that was good news on a Friday night. 👍

@jwikman
Copy link
Contributor Author

jwikman commented May 20, 2019

@roblourens , is this included in the v1.34 release? Didn't see anything in the release notes. ;-)

@roblourens
Copy link
Member

Yep it's there

@jwikman
Copy link
Contributor Author

jwikman commented May 20, 2019

Yep it's there

OK, thanks

@roblourens
Copy link
Member

Oh I forgot to add this to the milestone so it wasn't included in the release notes. I'll fix that and it will show up next time the website is updated. Sorry!

@roblourens roblourens added this to the April 2019 milestone May 20, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants