-
Notifications
You must be signed in to change notification settings - Fork 31.9k
FindInFiles converted to command and accepting arguments #71626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@roblourens - Code is modified to use an args variable when calling setSearchParameters (which is renamed) Did you get a few minutes to think about the trigger search parameter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this, but I am going to keep thinking about triggerSearch, and I reserve the right to revert it before the next stable release :)
Thanks for the PR!
Btw, thinking about it more, I think all of this is fine, including allowing an extension to trigger the search, and I look forward to seeing what people use it for! |
Thanks @roblourens, that was good news on a Friday night. 👍 |
@roblourens , is this included in the v1.34 release? Didn't see anything in the release notes. ;-) |
Yep it's there |
OK, thanks |
Oh I forgot to add this to the milestone so it wasn't included in the release notes. I'll fix that and it will show up next time the website is updated. Sorry! |
Tries to solve #29405