Skip to content

add .vscodeignore syntax highlighting #64960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

donaldpipowitch
Copy link
Contributor

I have no idea, if this is the correct way to do it 😄 I created a new extension called just vscode to handle VS Code specific features. I could imagine to have more VS Code specific functionality in the form of a built-in extension (e.g. also for things like .vscode/* files).

I guess current VS Code specific features are currently included somewhere in the src/? But I'm not sure if you want to maintain language-to-file-mappings there as well. I'm happy to move this change to a different place and to hear feedback! 😄

@aeschli
Copy link
Contributor

aeschli commented Jan 4, 2019

The correct place for this is extensions/extension-editing.

I made the change. Still, thanks for the PR @donaldpipowitch !

@aeschli aeschli added this to the December/January 2019 milestone Jan 4, 2019
@donaldpipowitch
Copy link
Contributor Author

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants