Skip to content

Fix #64253 - Support ~/ paths for typescript.tsdk #64892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

skprabhanjan
Copy link
Contributor

@mjbvz , Here is an implementation based on the inputs you gave to fix #64253 .
Please review this and let me know if anything needs to be changed :)
Thanks!

@mjbvz mjbvz self-assigned this Dec 12, 2018
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! Just a small requested change

@mjbvz mjbvz added this to the December/January 2019 milestone Dec 14, 2018
@mjbvz mjbvz merged commit 0f5b2d1 into microsoft:master Dec 14, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 14, 2018

Thanks!

@skprabhanjan skprabhanjan deleted the fix-64253 branch December 17, 2018 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ~/ paths for typescript.tsdk
3 participants