-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Search: Improvements to clear button behavior #63082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Improvements to clear button behavior #63082
Conversation
… cleared and enabled clear button after any input in search form.
… to use onDidChange
…of only search inputs
great |
…r to access onDidChange event. Changed event listeners in SearchView to use onDidChange events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Is there a way to restore the original behavior? I keep around a list of exclusions that I sometimes swap between include/exclude (e.g. tests). |
@WinnieP Are you saying that you'd prefer the include/exclude boxes to not clear when the clear button is pressed? |
@aechan Yes, I personally preferred it when those 2 boxes were not cleared when clearing results. |
@WinnieP I would recommend opening an issue for that then. |
Issue: #62952
Made a few improvements to the behavior of the search clear button based off the suggestions in the above issue.
The clear button now: