Skip to content

Search: Improvements to clear button behavior #63082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2018

Conversation

aechan
Copy link
Contributor

@aechan aechan commented Nov 14, 2018

Issue: #62952

Made a few improvements to the behavior of the search clear button based off the suggestions in the above issue.

The clear button now:

  • Enables after any input to any input box in the search form
  • Disables after input is cleared from all input boxes in the search form
  • Clears all input from the search form now including the include and exclude filters

… cleared and enabled clear button after any input in search form.
@msftclas
Copy link

msftclas commented Nov 14, 2018

CLA assistant check
All CLA requirements met.

@roblourens roblourens self-assigned this Nov 14, 2018
@gowtham9494
Copy link

great

@roblourens roblourens added this to the December 2018 milestone Nov 30, 2018
…r to access onDidChange event. Changed event listeners in SearchView to use onDidChange events.
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit c4cbb9f into microsoft:master Dec 10, 2018
@WinnieP
Copy link

WinnieP commented Feb 6, 2019

Is there a way to restore the original behavior? I keep around a list of exclusions that I sometimes swap between include/exclude (e.g. tests).

@aechan
Copy link
Contributor Author

aechan commented Feb 6, 2019

@WinnieP Are you saying that you'd prefer the include/exclude boxes to not clear when the clear button is pressed?

@WinnieP
Copy link

WinnieP commented Feb 6, 2019

@aechan Yes, I personally preferred it when those 2 boxes were not cleared when clearing results.

@aechan
Copy link
Contributor Author

aechan commented Feb 6, 2019

@WinnieP I would recommend opening an issue for that then.

@aechan aechan deleted the aechan/search-clear-feature branch February 6, 2019 23:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants